Skip to content

Commit dc7ea3d

Browse files
author
Frank Natividad
committed
address comments
1 parent 8b01905 commit dc7ea3d

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

storage/src/delete_hmac_key.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ function delete_hmac_key($accessId, $projectId)
4040
$hmacKey = $storage->hmacKey($accessId, $projectId);
4141

4242
$hmacKey->delete();
43-
print("The key is deleted, though it may still appear in StorageClient.hmacKeys() results." . PHP_EOL);
43+
print("The key is deleted, though it may still appear in StorageClient.hmacKeys(\$options=['showDeletedKeys'=>true])");
44+
print("results when is used." . PHP_EOL);
4445
}
4546
# [END storage_get_hmac_key]

storage/storage.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,7 @@
476476
->addArgument('accessId', InputArgument::REQUIRED, 'The Cloud Storage HMAC key access Id')
477477
->addOption('activate', null, InputOption::VALUE_NONE, 'Activate an HMAC key')
478478
->addOption('deactivate', null, InputOption::VALUE_NONE, 'Deactivate an HMAC key')
479-
->addOption('get', null, InputOption::VALUE_NONE, 'Get an HMAC key metadata')
479+
->addOption('get', null, InputOption::VALUE_NONE, 'Get an HMAC key\'s metadata')
480480
->addOption('delete', null, InputOption::VALUE_NONE, 'Delete an HMAC key')
481481
->setCode(function ($input, $output) {
482482
$projectId = $input->getArgument('projectId');

storage/test/HmacCommandTest.php

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ public function testHmacKeyGet()
107107
}
108108

109109
/** @depends testHmacKeyGet */
110-
public function testHmacKeyDeactivateActivate()
110+
public function testHmacKeyActivate()
111111
{
112112
$this->commandTesterManage->execute(
113113
[
@@ -117,6 +117,11 @@ public function testHmacKeyDeactivateActivate()
117117
],
118118
['interactive' => false]);
119119
$this->assertContains("The HMAC key is now inactive", $this->getActualOutput());
120+
121+
}
122+
123+
/** @depends testHmacKeyActivate */
124+
public function testHmacKeyDeactivate() {
120125
$this->commandTesterManage->execute(
121126
[
122127
'projectId' => self::$projectId,
@@ -126,7 +131,8 @@ public function testHmacKeyDeactivateActivate()
126131
['interactive' => false]);
127132
$this->assertContains("The HMAC key is now active", $this->getActualOutput());
128133
}
129-
/** @depends testHmacKeyDeactivateActivate */
134+
135+
/** @depends testHmacKeyDeactivate */
130136
public function testHmacKeyDelete()
131137
{
132138
$this->commandTesterManage->execute(

0 commit comments

Comments
 (0)