fix: upgrade and fix asset samples (GoogleCloudPlatform#1413)

bshaffer · web-flow · commit d9b29692c4f1 · 2021-06-18T09:13:58.000-07:00
diff --git a/asset/composer.json b/asset/composer.json
@@ -2,6 +2,6 @@
     "require": {
         "google/cloud-bigquery": "^1.16.0",
         "google/cloud-storage": "^1.9",
-        "google/cloud-asset": "^1.2.0"
+        "google/cloud-asset": "^1.4.2"
     }
 }
diff --git a/asset/src/batch_get_assets_history.php b/asset/src/batch_get_assets_history.php
@@ -23,7 +23,7 @@
 use Google\Cloud\Asset\V1\TimeWindow;
 use Google\Protobuf\Timestamp;
 
-function batch_get_assets_history(string $projectId, string $assetNames)
+function batch_get_assets_history(string $projectId, array $assetNames)
 {
     $client = new AssetServiceClient();
     $formattedParent = $client->projectName($projectId);
diff --git a/testing/run_test_suite.sh b/testing/run_test_suite.sh
@@ -23,7 +23,6 @@ fi
 FLAKES=(
     # Add directories here to run the tests but ignore them if they fail
     datastore/api
-    asset
 )
 
 # Directories we do not want to run tests in, even if they exist

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@`
`23`	`23`	`use Google\Cloud\Asset\V1\TimeWindow;`
`24`	`24`	`use Google\Protobuf\Timestamp;`
`25`	`25`
`26`		`-function batch_get_assets_history(string $projectId, string $assetNames)`
	`26`	`+function batch_get_assets_history(string $projectId, array $assetNames)`
`27`	`27`	`{`
`28`	`28`	`$client = new AssetServiceClient();`
`29`	`29`	`$formattedParent = $client->projectName($projectId);`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,6 @@ fi`
`23`	`23`	`FLAKES=(`
`24`	`24`	`# Add directories here to run the tests but ignore them if they fail`
`25`	`25`	`datastore/api`
`26`		`- asset`
`27`	`26`	`)`
`28`	`27`
`29`	`28`	`# Directories we do not want to run tests in, even if they exist`