chore: fix dlp trigger tests (GoogleCloudPlatform#1432)

Author: bshaffer

dlp/src/list_jobs.php

@@ -36,6 +36,7 @@
  * List Data Loss Prevention API jobs corresponding to a given filter.
  */
 use Google\Cloud\Dlp\V2\DlpServiceClient;
+use Google\Cloud\Dlp\V2\DlpJob\JobState;
 use Google\Cloud\Dlp\V2\DlpJobType;
 
 /** Uncomment and populate these variables in your code */
@@ -63,16 +64,18 @@
     printf('Job %s status: %s' . PHP_EOL, $job->getName(), $job->getState());
     $infoTypeStats = $job->getInspectDetails()->getResult()->getInfoTypeStats();
 
-    if (count($infoTypeStats) > 0) {
-        foreach ($infoTypeStats as $infoTypeStat) {
-            printf(
-                '  Found %s instance(s) of type %s' . PHP_EOL,
-                $infoTypeStat->getCount(),
-                $infoTypeStat->getInfoType()->getName()
-            );
+    if ($job->getState() == JobState::DONE) {
+        if (count($infoTypeStats) > 0) {
+            foreach ($infoTypeStats as $infoTypeStat) {
+                printf(
+                    '  Found %s instance(s) of type %s' . PHP_EOL,
+                    $infoTypeStat->getCount(),
+                    $infoTypeStat->getInfoType()->getName()
+                );
+            }
+        } else {
+            print('  No findings.' . PHP_EOL);
         }
-    } else {
-        print('  No findings.' . PHP_EOL);
     }
 }
 # [END dlp_list_jobs]

dlp/test/dlpTest.php

@@ -168,6 +168,11 @@ public function testDeidReidFPE()
     public function testTriggers()
     {
         $bucketName = $this->requireEnv('GOOGLE_STORAGE_BUCKET');
+        // Use a different bucket for triggers so we don't trigger a bunch of
+        // DLP jobs on our actual storage bucket. This will create the trigger
+        // on a nonexistant bucket.
+        $bucketName .= '-dlp-triggers';
+
         $displayName = uniqid("My trigger display name ");
         $description = uniqid("My trigger description ");
         $triggerId = uniqid('my-php-test-trigger-');