Skip to content

Commit d52148d

Browse files
committed
address review comments
1 parent 1b728f5 commit d52148d

File tree

4 files changed

+2
-5
lines changed

4 files changed

+2
-5
lines changed

cloud_sql/postgres/pdo/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ Navigate towards http://localhost:8080 to verify your application is running cor
7070

7171
To run on App Engine Flex, create an App Engine project by following the setup for these [instructions](https://cloud.google.com/appengine/docs/standard/php7/quickstart#before-you-begin).
7272

73-
First, update `app.yaml` with the correct values to pass the environment variables into the runtime.
73+
First, update `app.flex.yaml` with the correct values to pass the environment variables into the runtime.
7474

7575
Then, make sure that the service account `service-{PROJECT_NUMBER}>@gae-api-prod.google.com.iam.gserviceaccount.com` has the IAM role `Cloud SQL Client`.
7676

cloud_sql/postgres/pdo/composer.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,5 @@
1717
"pimple/pimple": "^3.3",
1818
"guzzlehttp/psr7": "^1.6",
1919
"http-interop/http-factory-guzzle": "^1.0"
20-
},
21-
"require-dev": {
22-
"phpunit/phpunit": "^8.5"
2320
}
2421
}

cloud_sql/postgres/pdo/phpunit.xml.dist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
xml version="1.0" encoding="UTF-8"?>
2-
<phpunit colors="true">
2+
<phpunit colors="true" bootstrap="../../../testing/bootstrap.php">
33
<testsuites>
44
<testsuite name="CloudSQLPostgresSample">
55
<directory>testsdirectory>

0 commit comments

Comments
 (0)