Skip to content

Commit c4758b2

Browse files
authored
Fixes pubsub push subscription sample (GoogleCloudPlatform#969)
1 parent 302781e commit c4758b2

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

pubsub/api/src/create_push_subscription.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ function create_push_subscription($projectId, $topicName, $subscriptionName, $en
4242
$topic = $pubsub->topic($topicName);
4343
$subscription = $topic->subscription($subscriptionName);
4444
$subscription->create([
45-
'endpoint' => $endpoint
45+
'pushConfig' => ['pushEndpoint' => $endpoint]
4646
]);
4747

4848
printf('Subscription created: %s' . PHP_EOL, $subscription->name());

pubsub/api/test/pubsubTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,10 +209,11 @@ public function testCreateAndDeletePushSubscription()
209209
{
210210
$topic = $this->requireEnv('GOOGLE_PUBSUB_TOPIC');
211211
$subscription = 'test-subscription-' . rand();
212+
$fakeUrl = sprintf('https://%s.appspot.com/receive_message', self::$projectId);
212213
$output = $this->runCommand('subscription', [
213214
'subscription' => $subscription,
214215
'--topic' => $topic,
215-
'--endpoint' => 'https://example.com/receive_message',
216+
'--endpoint' => $fakeUrl,
216217
'--create' => true,
217218
'project' => self::$projectId,
218219
]);

0 commit comments

Comments
 (0)