Skip to content

Commit b51d3c9

Browse files
authored
Makes troublesome Spanner test eventually consistent (GoogleCloudPlatform#934)
1 parent a0680ad commit b51d3c9

File tree

1 file changed

+9
-11
lines changed

1 file changed

+9
-11
lines changed

spanner/test/spannerTest.php

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,13 @@
2020
use Google\Cloud\Spanner\SpannerClient;
2121
use Google\Cloud\Spanner\Instance;
2222
use Google\Cloud\TestUtils\ExecuteCommandTrait;
23+
use Google\Cloud\TestUtils\EventuallyConsistentTestTrait;
2324
use Google\Cloud\TestUtils\TestTrait;
2425
use PHPUnit\Framework\TestCase;
2526

2627
class spannerTest extends TestCase
2728
{
28-
use TestTrait, ExecuteCommandTrait {
29+
use TestTrait, EventuallyConsistentTestTrait, ExecuteCommandTrait {
2930
ExecuteCommandTrait::runCommand as traitRunCommand;
3031
}
3132

@@ -61,11 +62,6 @@ public static function setUpBeforeClass()
6162
self::$instance = $spanner->instance(self::$instanceId);
6263
}
6364

64-
public function setUp()
65-
{
66-
$this->useExpectationFailedBackoff();
67-
}
68-
6965
public function testCreateDatabase()
7066
{
7167
$output = $this->runCommand('create-database');
@@ -573,11 +569,13 @@ public function testQueryDataWithStringParameter()
573569
*/
574570
public function testQueryDataWithTimestampParameter()
575571
{
576-
$output = $this->runCommand('query-data-with-timestamp-parameter');
577-
self::$lastUpdateDataTimestamp = time();
578-
$this->assertContains('VenueId: 4, VenueName: Venue 4, LastUpdateTime:', $output);
579-
$this->assertContains('VenueId: 19, VenueName: Venue 19, LastUpdateTime:', $output);
580-
$this->assertContains('VenueId: 42, VenueName: Venue 42, LastUpdateTime:', $output);
572+
$this->runEventuallyConsistentTest(function () {
573+
$output = $this->runCommand('query-data-with-timestamp-parameter');
574+
self::$lastUpdateDataTimestamp = time();
575+
$this->assertContains('VenueId: 4, VenueName: Venue 4, LastUpdateTime:', $output);
576+
$this->assertContains('VenueId: 19, VenueName: Venue 19, LastUpdateTime:', $output);
577+
$this->assertContains('VenueId: 42, VenueName: Venue 42, LastUpdateTime:', $output);
578+
});
581579
}
582580

583581
private function runCommand($commandName)

0 commit comments

Comments
 (0)