fixes appengine standard cloudsql test skip statment (GoogleCloudPlatform#229)

bshaffer · web-flow · commit 6320a96e9529 · 2016-10-27T09:18:45.000-06:00
diff --git a/appengine/standard/cloudsql/test/cloudsqlTest.php b/appengine/standard/cloudsql/test/cloudsqlTest.php
@@ -30,7 +30,7 @@ public function createApplication()
         $dsn = getenv('MYSQL_DSN');
         $username = getenv('MYSQL_USERNAME');
         $password = getenv('MYSQL_PASSWORD');
-        if (!isset($dsn, $username) || false === $password) {
+        if (empty($dsn) || empty($username) || false === $password) {
             $this->markTestSkipped('set the MYSQL_DSN, MYSQL_USER and MYSQL_PASSWORD environment variables');
         }
 

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ public function createApplication()`
`30`	`30`	`$dsn = getenv('MYSQL_DSN');`
`31`	`31`	`$username = getenv('MYSQL_USERNAME');`
`32`	`32`	`$password = getenv('MYSQL_PASSWORD');`
`33`		`- if (!isset($dsn, $username) \|\| false === $password) {`
	`33`	`+ if (empty($dsn) \|\| empty($username) \|\| false === $password) {`
`34`	`34`	`$this->markTestSkipped('set the MYSQL_DSN, MYSQL_USER and MYSQL_PASSWORD environment variables');`
`35`	`35`	`}`
`36`	`36`