Skip to content

Commit 261318a

Browse files
authored
fix(vision): add fix for changing vision model test (GoogleCloudPlatform#1098)
1 parent 2e66e51 commit 261318a

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

appengine/flexible/helloworld/composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"require": {
3-
"php": "5.6.*|7.0.*|7.1.*|7.2.*",
3+
"php": "5.6.*|7.0.*|7.1.*|7.2.*|7.3.*",
44
"silex/silex": "^2.3"
55
},
66
"require-dev": {

vision/test/visionTest.php

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,10 @@ public function testLandmarkCommand()
124124
{
125125
$path = __DIR__ . '/data/tower.jpg';
126126
$output = $this->runCommand('landmark', ['path' => $path]);
127-
$this->assertContains('Champ de Mars', $output);
127+
$this->assertRegexp(
128+
'/Eiffel Tower|Champ de Mars|Trocadéro Gardens/',
129+
$output
130+
);
128131
}
129132

130133
public function testLandmarkCommandGcs()
@@ -133,7 +136,10 @@ public function testLandmarkCommandGcs()
133136

134137
$path = 'gs://' . $bucketName . '/vision/tower.jpg';
135138
$output = $this->runCommand('landmark', ['path' => $path]);
136-
$this->assertContains('Champ de Mars', $output);
139+
$this->assertRegexp(
140+
'/Eiffel Tower|Champ de Mars|Trocadéro Gardens/',
141+
$output
142+
);
137143
}
138144

139145
public function testLandmarkCommandWithImageLackingLandmarks()

0 commit comments

Comments
 (0)