Skip to content

Commit 20b907a

Browse files
author
Ace Nassri
authored
tests: update test names to suggested format (GoogleCloudPlatform#1104)
1 parent f9f6980 commit 20b907a

File tree

8 files changed

+20
-19
lines changed

8 files changed

+20
-19
lines changed

appengine/php55/cloudsql/test/LocalTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public function createApplication()
4040
return $app;
4141
}
4242

43-
public function testHome()
43+
public function test_gaePhpMysqlApp_shouldTestHome()
4444
{
4545
$client = $this->createClient();
4646

appengine/php55/grpc/spanner.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
* limitations under the License.
1616
*/
1717

18+
// [START spanner_quickstart]
1819
# Includes the autoloader for libraries installed with composer
1920
require __DIR__ . '/vendor/autoload.php';
2021

appengine/php55/grpc/test/DeployTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public static function beforeDeploy()
6060
}
6161
}
6262

63-
public function testSpanner()
63+
public function test_spannerQuickstart()
6464
{
6565
if (!getenv('SPANNER_INSTANCE_ID') || !getenv('SPANNER_DATABASE_ID')) {
6666
$this->markTestSkipped('Set the SPANNER_INSTANCE_ID and SPANNER_DATABASE_ID ' .

appengine/php55/http/test/LocalTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public function testHome()
4141
$this->assertTrue($client->getResponse()->isOk());
4242
}
4343

44-
public function testFileRequest()
44+
public function test_gaeIssueRequestHttpBin_shouldTestFileRequest()
4545
{
4646
$client = $this->createClient();
4747

@@ -53,7 +53,7 @@ public function testFileRequest()
5353
$this->assertResponse((string) $client->getResponse());
5454
}
5555

56-
public function testCurlRequest()
56+
public function test_gaeIssueRequestCurlRequest_shouldTestCurlRequest()
5757
{
5858
$client = $this->createClient();
5959

appengine/php55/mail/test/LocalTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
class LocalTest extends TestCase
2323
{
24-
public function testSendMail()
24+
public function test_gaeMailApi_shouldTestSendMail()
2525
{
2626
ob_start();
2727
include __DIR__ . '/../index.php';

appengine/php55/mailjet/test/LocalTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public function createApplication()
3838
return $app;
3939
}
4040

41-
public function testHome()
41+
public function test_gaeMailjetImport_shouldTestHome()
4242
{
4343
$client = $this->createClient();
4444

@@ -47,7 +47,7 @@ public function testHome()
4747
$this->assertTrue($client->getResponse()->isOk());
4848
}
4949

50-
public function testSendEmail()
50+
public function test_gaeMailjetImport_gaeMailjetSendMessage_shouldTestSendEmail()
5151
{
5252
$client = $this->createClient();
5353

appengine/php55/storage/test/LocalTest.php

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public function createApplication()
4545
return $app;
4646
}
4747

48-
public function testHome()
48+
public function test_userUpload_shouldTestHome()
4949
{
5050
$client = $this->createClient();
5151

@@ -54,7 +54,7 @@ public function testHome()
5454
$this->assertTrue($client->getResponse()->isOk());
5555
}
5656

57-
public function testRead()
57+
public function test_readSimple_shouldTestRead()
5858
{
5959
$client = $this->createClient();
6060

@@ -67,7 +67,7 @@ public function testRead()
6767
$this->assertEquals($response->getContent(), $fileTxt);
6868
}
6969

70-
public function testWrite()
70+
public function test_readMetadata_userUpload_writeCaching_writeDefault_writeDefaultStream_writeMetadata_writeOptions_writePublic_writeSimple_writeStream_shouldTestWrite()
7171
{
7272
$client = $this->createClient();
7373

@@ -85,7 +85,7 @@ public function testWrite()
8585
$this->assertContains($time, $response->getContent());
8686
}
8787

88-
public function testWriteOptions()
88+
public function test_userUpload_writeOptions_shouldTestWriteOptions()
8989
{
9090
$client = $this->createClient();
9191

@@ -103,7 +103,7 @@ public function testWriteOptions()
103103
$this->assertContains($time, $response->getContent());
104104
}
105105

106-
public function testWriteStream()
106+
public function test_userUpload_writeStream_shouldTestWriteStream()
107107
{
108108
$client = $this->createClient();
109109

@@ -121,7 +121,7 @@ public function testWriteStream()
121121
$this->assertContains($time, $response->getContent());
122122
}
123123

124-
public function testWriteCaching()
124+
public function test_userUpload_writeCaching_shouldTestWriteCaching()
125125
{
126126
$client = $this->createClient();
127127

@@ -139,7 +139,7 @@ public function testWriteCaching()
139139
$this->assertContains($time, $response->getContent());
140140
}
141141

142-
public function testWriteMetadata()
142+
public function test_readMetadata_userUpload_writeMetadata_shouldTestWriteMetadata()
143143
{
144144
$client = $this->createClient();
145145

@@ -166,7 +166,7 @@ public function testWriteMetadata()
166166
}
167167
}
168168

169-
public function testWriteDefault()
169+
public function test_userUpload_writeDefault_shouldTestWriteDefault()
170170
{
171171
$client = $this->createClient();
172172

@@ -184,7 +184,7 @@ public function testWriteDefault()
184184
$this->assertContains($time, $response->getContent());
185185
}
186186

187-
public function testWriteDefaultStream()
187+
public function test_userUpload_writeDefaultStream_shouldTestWriteDefaultStream()
188188
{
189189
$client = $this->createClient();
190190

@@ -202,7 +202,7 @@ public function testWriteDefaultStream()
202202
$this->assertContains($time, $response->getContent());
203203
}
204204

205-
public function testServe()
205+
public function test_imageServe_readServe_shouldTestServe()
206206
{
207207
$client = $this->createClient();
208208

@@ -214,7 +214,7 @@ public function testServe()
214214
$this->assertContains('This is the contents of a file', CloudStorageTools::$served);
215215
}
216216

217-
public function testWritePublic()
217+
public function test_writePublic_shouldTestWritePublic()
218218
{
219219
$client = $this->createClient();
220220

appengine/php55/twilio/test/LocalTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public function testSendText()
6060
$this->assertTrue($client->getResponse()->isOk());
6161
}
6262

63-
public function testTwiml()
63+
public function test_twiml_shouldTestTwiml()
6464
{
6565
$client = $this->createClient();
6666

0 commit comments

Comments
 (0)