Skip to content

Commit dd253fe

Browse files
authored
samples(spanner): PITR samples backup fix (GoogleCloudPlatform#1293)
1 parent df03e29 commit dd253fe

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

spanner/src/create_backup.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,24 +31,24 @@
3131
* Create a backup.
3232
* Example:
3333
* ```
34-
* create_backup($instanceId, $databaseId, $backupId);
34+
* create_backup($instanceId, $databaseId, $backupId, $versionTime);
3535
* ```
3636
*
3737
* @param string $instanceId The Spanner instance ID.
3838
* @param string $databaseId The Spanner database ID.
3939
* @param string $backupId The Spanner backup ID.
40+
* @param string $versionTime The version of the database to backup.
4041
*/
41-
function create_backup($instanceId, $databaseId, $backupId)
42+
function create_backup($instanceId, $databaseId, $backupId, $versionTime)
4243
{
4344
$spanner = new SpannerClient();
4445
$instance = $spanner->instance($instanceId);
4546
$database = $instance->database($databaseId);
4647

4748
$expireTime = new \DateTime('+14 days');
48-
$versionTime = new \DateTime($database->info()['earliestVersionTime']);
4949
$backup = $instance->backup($backupId);
5050
$operation = $backup->create($database->name(), $expireTime, [
51-
'versionTime' => $versionTime
51+
'versionTime' => new \DateTime($versionTime)
5252
]);
5353

5454
print('Waiting for operation to complete...' . PHP_EOL);

spanner/test/spannerBackupTest.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,15 @@ public function testCancelBackup()
102102
*/
103103
public function testCreateBackup()
104104
{
105+
$database = self::$instance->database(self::$databaseId);
106+
$results = $database->execute("SELECT TIMESTAMP_TRUNC(CURRENT_TIMESTAMP(), MICROSECOND) as Timestamp");
107+
$row = $results->rows()->current();
108+
$versionTime = $row['Timestamp'];
109+
105110
$output = $this->runFunctionSnippet('create_backup', [
106111
self::$databaseId,
107112
self::$backupId,
113+
$versionTime,
108114
]);
109115
$this->assertStringContainsString(self::$backupId, $output);
110116
}

0 commit comments

Comments
 (0)