Skip to content

Commit a0d55e0

Browse files
authored
fix: flex logging and iot tests (GoogleCloudPlatform#1156)
1 parent 4d73cd0 commit a0d55e0

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

appengine/flexible/logging/app.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
$logger = $logging->logger('logging-sample');
4040
$logs = $logger->entries([
4141
'pageSize' => 10,
42+
'resultLimit' => 10,
4243
'orderBy' => 'timestamp desc'
4344
]);
4445
return $app['twig']->render('index.html.twig', ['logs' => $logs]);

iot/composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"type": "project",
44
"require": {
55
"google/cloud-iot": "^1.0.0",
6-
"symfony/console": "^3.3"
6+
"symfony/console": "^4.0"
77
},
88
"autoload": {
99
"files": [

iot/test/iotTest.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,14 @@
2121
use Google\Cloud\TestUtils\ExecuteCommandTrait;
2222
use Google\Cloud\TestUtils\TestTrait;
2323
use PHPUnit\Framework\TestCase;
24+
use PHPUnitRetry\RetryTrait;
2425

2526
/**
2627
* Unit Tests for iot commands.
2728
*/
2829
class iotTest extends TestCase
2930
{
30-
use TestTrait, ExecuteCommandTrait;
31+
use TestTrait, ExecuteCommandTrait, RetryTrait;
3132

3233
private static $commandFile = __DIR__ . '/../iot.php';
3334
private static $testId;
@@ -290,7 +291,10 @@ public function testCreateGateway()
290291
$this->assertContains($gatewayId, $output);
291292
}
292293

293-
/** @depends testCreateGateway */
294+
/**
295+
* @depends testCreateGateway
296+
* @retryAttempts 3
297+
*/
294298
public function testBindUnbindDevice()
295299
{
296300
$deviceId = 'test-device-to-bind' . self::$testId;

0 commit comments

Comments
 (0)