Skip to content

Fix doctest q fourier transform.py #9943 #10624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix doctest q fourier transform.py #9943 #10624

wants to merge 2 commits into from

Conversation

Jaivignesh-afk
Copy link
Contributor

Describe your change:

I have corrected failure examples in the doctests and added testmod function to the program
Contributes to #9943

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Contributes to Improve our test coverage #9943 ".

@Jaivignesh-afk
Copy link
Contributor Author

I don't know what's wrong here, in my local system I'm getting 91% cover.Can anyone help me out with this?

cclauss
cclauss reviewed Oct 17, 2023
View reviewed changes
quantum/q_fourier_transform.py
Comment on lines -93 to -96
print(
f"Total count for quantum fourier transform state is: \
{quantum_fourier_transform(3)}"
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

Copy link
Contributor Author

@Jaivignesh-afk Jaivignesh-afk Oct 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i got error relating to more no of lines in the pre-commit.So i checked with other algorithms there were no print statements..So,but i can change it back
I think, qiskit module is not yet available for Python 3.12 +
maybe that is the reason?

@cclauss
Copy link
Member

cclauss commented Oct 17, 2023

https://about.codecov.io/blog/the-case-against-100-code-coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss left review comments

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jaivignesh-afk @cclauss