Fix flaky tests by running slow deletion as a background task (GoogleCloudPlatform#7159)

dinagraves · parthea · leahecole · web-flow · commit c0cca0b95767 · 2021-12-02T13:29:23.000-05:00
* Async deletion for cloud run

* Memorystore async deletion for cloud run

* Update auth_test.py

Co-authored-by: Anthonios Partheniou &lt;partheniou@google.com&gt;
Co-authored-by: Leah E. Cole &lt;6719667+leahecole@users.noreply.github.com&gt;
diff --git a/auth/service-to-service/auth_test.py b/auth/service-to-service/auth_test.py
@@ -85,6 +85,7 @@ def services():
         [
             "gcloud", "run", "services", "delete", f"helloworld-{suffix}",
             "--project", project,
+            "--async",
             "--platform=managed",
             "--region=us-central1",
             "--quiet",
@@ -96,6 +97,7 @@ def services():
         [
             "gcloud", "functions", "delete", f"helloworld-{suffix}",
             "--project", project,
+            "--async",
             "--region=us-central1",
             "--quiet",
          ],
diff --git a/memorystore/redis/cloud_run_deployment/e2e_test.py b/memorystore/redis/cloud_run_deployment/e2e_test.py
@@ -134,6 +134,7 @@ def deployed_service(container_image, redis_host):
             "--platform=managed",
             "--region=us-central1",
             "--quiet",
+            "--async",
             "--project",
             PROJECT,
         ]
diff --git a/run/filesystem/e2e_test.py b/run/filesystem/e2e_test.py
@@ -61,6 +61,7 @@ def deployed_service():
             '--region=us-central1',
             '--platform=managed',
             '--quiet',
+            "--async",
             '--project',
             PROJECT,
         ]
diff --git a/run/hello-broken/e2e_test.py b/run/hello-broken/e2e_test.py
@@ -94,6 +94,7 @@ def deployed_service(container_image):
             "--platform=managed",
             "--region=us-central1",
             "--quiet",
+            "--async",
             "--project",
             PROJECT,
         ]
diff --git a/run/helloworld/e2e_test.py b/run/helloworld/e2e_test.py
@@ -95,6 +95,7 @@ def deployed_service(container_image):
             "--platform=managed",
             "--region=us-central1",
             "--quiet",
+            "--async",
             "--project",
             PROJECT,
         ]
diff --git a/run/image-processing/e2e_test.py b/run/image-processing/e2e_test.py
@@ -102,6 +102,7 @@ def deployed_service(container_image, output_bucket):
             "--platform=managed",
             "--region=us-central1",
             "--quiet",
+            "--async",
             "--project",
             PROJECT,
         ]
diff --git a/run/logging-manual/e2e_test.py b/run/logging-manual/e2e_test.py
@@ -101,6 +101,7 @@ def deployed_service(container_image):
             "--platform=managed",
             "--region=us-central1",
             "--quiet",
+            "--async",
             "--project",
             PROJECT,
         ]
diff --git a/run/markdown-preview/e2e_test.py b/run/markdown-preview/e2e_test.py
@@ -129,6 +129,7 @@ def renderer_deployed_service(renderer_image):
             "--platform=managed",
             "--region=us-central1",
             "--quiet",
+            "--async",
             "--project",
             PROJECT,
         ]
diff --git a/run/pubsub/e2e_test.py b/run/pubsub/e2e_test.py
@@ -99,6 +99,7 @@ def deployed_service(container_image):
             "--platform=managed",
             "--region=us-central1",
             "--quiet",
+            "--async",
             "--project",
             PROJECT,
         ]
diff --git a/run/system-package/e2e_test.py b/run/system-package/e2e_test.py
@@ -97,6 +97,7 @@ def deployed_service(container_image):
             "--platform=managed",
             "--region=us-central1",
             "--quiet",
+            "--async",
             "--project",
             PROJECT,
         ]

Original file line number	Diff line number	Diff line change
`@@ -134,6 +134,7 @@ def deployed_service(container_image, redis_host):`
`134`	`134`	`"--platform=managed",`
`135`	`135`	`"--region=us-central1",`
`136`	`136`	`"--quiet",`
	`137`	`+ "--async",`
`137`	`138`	`"--project",`
`138`	`139`	`PROJECT,`
`139`	`140`	`]`
Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,7 @@ def deployed_service():`
`61`	`61`	`'--region=us-central1',`
`62`	`62`	`'--platform=managed',`
`63`	`63`	`'--quiet',`
	`64`	`+ "--async",`
`64`	`65`	`'--project',`
`65`	`66`	`PROJECT,`
`66`	`67`	`]`
Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,7 @@ def deployed_service(container_image):`
`94`	`94`	`"--platform=managed",`
`95`	`95`	`"--region=us-central1",`
`96`	`96`	`"--quiet",`
	`97`	`+ "--async",`
`97`	`98`	`"--project",`
`98`	`99`	`PROJECT,`
`99`	`100`	`]`
Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,7 @@ def deployed_service(container_image):`
`95`	`95`	`"--platform=managed",`
`96`	`96`	`"--region=us-central1",`
`97`	`97`	`"--quiet",`
	`98`	`+ "--async",`
`98`	`99`	`"--project",`
`99`	`100`	`PROJECT,`
`100`	`101`	`]`
Original file line number	Diff line number	Diff line change
`@@ -102,6 +102,7 @@ def deployed_service(container_image, output_bucket):`
`102`	`102`	`"--platform=managed",`
`103`	`103`	`"--region=us-central1",`
`104`	`104`	`"--quiet",`
	`105`	`+ "--async",`
`105`	`106`	`"--project",`
`106`	`107`	`PROJECT,`
`107`	`108`	`]`
Original file line number	Diff line number	Diff line change
`@@ -101,6 +101,7 @@ def deployed_service(container_image):`
`101`	`101`	`"--platform=managed",`
`102`	`102`	`"--region=us-central1",`
`103`	`103`	`"--quiet",`
	`104`	`+ "--async",`
`104`	`105`	`"--project",`
`105`	`106`	`PROJECT,`
`106`	`107`	`]`
Original file line number	Diff line number	Diff line change
`@@ -129,6 +129,7 @@ def renderer_deployed_service(renderer_image):`
`129`	`129`	`"--platform=managed",`
`130`	`130`	`"--region=us-central1",`
`131`	`131`	`"--quiet",`
	`132`	`+ "--async",`
`132`	`133`	`"--project",`
`133`	`134`	`PROJECT,`
`134`	`135`	`]`
Original file line number	Diff line number	Diff line change
`@@ -99,6 +99,7 @@ def deployed_service(container_image):`
`99`	`99`	`"--platform=managed",`
`100`	`100`	`"--region=us-central1",`
`101`	`101`	`"--quiet",`
	`102`	`+ "--async",`
`102`	`103`	`"--project",`
`103`	`104`	`PROJECT,`
`104`	`105`	`]`
Original file line number	Diff line number	Diff line change
`@@ -97,6 +97,7 @@ def deployed_service(container_image):`
`97`	`97`	`"--platform=managed",`
`98`	`98`	`"--region=us-central1",`
`99`	`99`	`"--quiet",`
	`100`	`+ "--async",`
`100`	`101`	`"--project",`
`101`	`102`	`PROJECT,`
`102`	`103`	`]`