From fb9042f77232bf30e3743e87fbcd1f1e2b29bde5 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Wed, 3 Nov 2010 13:41:53 -0400 Subject: [PATCH] Reduce recursion depth in recently-added regression test. Some buildfarm members fail the test with the original depth of 10 levels, apparently because they are running at the minimum max_stack_depth setting of 100kB and using ~ 10k per recursion level. While it might be interesting to try to figure out why they're eating so much stack, it isn't likely that any fix for that would be back-patchable. So just change the test to recurse only 5 levels. The extra levels don't prove anything correctness-wise anyway. --- src/test/regress/expected/plpgsql.out | 8 ++++---- src/test/regress/sql/plpgsql.sql | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/test/regress/expected/plpgsql.out b/src/test/regress/expected/plpgsql.out index 8e05cd0b560..4e0f0823017 100644 --- a/src/test/regress/expected/plpgsql.out +++ b/src/test/regress/expected/plpgsql.out @@ -3967,8 +3967,8 @@ DROP FUNCTION nonsimple_expr_test(); create function recurse(float8) returns float8 as $$ begin - if ($1 < 10) then - return sql_recurse($1 + 1); + if ($1 > 0) then + return sql_recurse($1 - 1); else return $1; end if; @@ -3977,10 +3977,10 @@ $$ language plpgsql; -- "limit" is to prevent this from being inlined create function sql_recurse(float8) returns float8 as $$ select recurse($1) limit 1; $$ language sql; -select recurse(0); +select recurse(5); recurse --------- - 10 + 0 (1 row) create function error1(text) returns text language sql as diff --git a/src/test/regress/sql/plpgsql.sql b/src/test/regress/sql/plpgsql.sql index 09fedd916d5..0de60d7073c 100644 --- a/src/test/regress/sql/plpgsql.sql +++ b/src/test/regress/sql/plpgsql.sql @@ -3174,8 +3174,8 @@ DROP FUNCTION nonsimple_expr_test(); create function recurse(float8) returns float8 as $$ begin - if ($1 < 10) then - return sql_recurse($1 + 1); + if ($1 > 0) then + return sql_recurse($1 - 1); else return $1; end if; @@ -3186,7 +3186,7 @@ $$ language plpgsql; create function sql_recurse(float8) returns float8 as $$ select recurse($1) limit 1; $$ language sql; -select recurse(0); +select recurse(5); create function error1(text) returns text language sql as $$ SELECT relname::text FROM pg_class c WHERE c.oid = $1::regclass $$; -- 2.39.5