Flush Memoize cache when non-key parameters change
authorDavid Rowley
Wed, 24 Nov 2021 01:57:07 +0000 (14:57 +1300)
committerDavid Rowley
Wed, 24 Nov 2021 01:57:07 +0000 (14:57 +1300)
commitf94edb06ab60545a0e9e90aedc39e3b81b2b9e3f
tree4e0eda31256137faf25e4237ec527eb563dc4b19
parent6c32c0977783fae217b5eaa1d22d26c96e5b0085
Flush Memoize cache when non-key parameters change

It's possible that a subplan below a Memoize node contains a parameter
from above the Memoize node.  If this parameter changes then cache entries
may become out-dated due to the new parameter value.

Previously Memoize was mistakenly not aware of this.  We fix this here by
flushing the cache whenever a parameter that's not part of the cache
key changes.

Bug: #17213
Reported by: Elvis Pranskevichus
Author: David Rowley
Discussion: https://postgr.es/m/17213-988ed34b225a2862@postgresql.org
Backpatch-through: 14, where Memoize was added
src/backend/executor/nodeMemoize.c
src/backend/nodes/bitmapset.c
src/backend/optimizer/plan/createplan.c
src/backend/optimizer/util/clauses.c
src/include/nodes/execnodes.h
src/include/nodes/plannodes.h
src/include/optimizer/clauses.h
src/test/regress/expected/memoize.out
src/test/regress/sql/memoize.sql