process startup: Always call Init[Auxiliary]Process() before BaseInit().
authorAndres Freund
Thu, 5 Aug 2021 21:37:09 +0000 (14:37 -0700)
committerAndres Freund
Thu, 5 Aug 2021 22:36:59 +0000 (15:36 -0700)
commitb406478b87e2234c0be4ca4105eee3bb466a646b
treeafe7c717314d513a9c372604d010b53a601763d4
parent0de13bbc47d19c95de132cc85c341fdab079c170
process startup: Always call Init[Auxiliary]Process() before BaseInit().

For EXEC_BACKEND InitProcess()/InitAuxiliaryProcess() needs to have been
called well before we call BaseInit(), as SubPostmasterMain() needs LWLocks to
work. Having the order of initialization differ between platforms makes it
unnecessarily hard to understand the system and to add initialization points
for new subsystems without a lot of duplication.

To be able to change the order, BaseInit() cannot trigger
CreateSharedMemoryAndSemaphores() anymore - obviously that needs to have
happened before we can call InitProcess(). It seems cleaner to create shared
memory explicitly in single user/bootstrap mode anyway.

After this change the separation of bufmgr initialization into
InitBufferPoolAccess() / InitBufferPoolBackend() is not meaningful anymore so
the latter is removed.

Author: Andres Freund 
Reviewed-By: Kyotaro Horiguchi
Discussion: https://postgr.es/m/20210802164124[email protected]
src/backend/bootstrap/bootstrap.c
src/backend/postmaster/autovacuum.c
src/backend/postmaster/auxprocess.c
src/backend/postmaster/bgworker.c
src/backend/storage/buffer/bufmgr.c
src/backend/tcop/postgres.c
src/backend/utils/init/postinit.c
src/include/storage/bufmgr.h