Rework XLogReader callback system
authorAlvaro Herrera
Fri, 8 May 2020 19:30:34 +0000 (15:30 -0400)
committerAlvaro Herrera
Fri, 8 May 2020 19:40:11 +0000 (15:40 -0400)
commitb060dbe0001a1d6bf26cd294710f3cb203868d46
tree6e9e980aa63ec1ec3655b93c92b9b5caa6689d38
parent871696ba20e0251e86041576373809d1c7ca161d
Rework XLogReader callback system

Code review for 0dc8ead46363, prompted by a bug closed by 91c40548d5f7.

XLogReader's system for opening and closing segments had gotten too
complicated, with callbacks being passed at both the XLogReaderAllocate
level (read_page) as well as at the WALRead level (segment_open).  This
was confusing and hard to follow, so restructure things so that these
callbacks are passed together at XLogReaderAllocate time, and add
another callback to the set (segment_close) to make it a coherent whole.
Also, ensure XLogReaderState is an argument to all the callbacks, so
that they can grab at the ->private data if necessary.

Document the whole arrangement more clearly.

Author: Álvaro Herrera 
Reviewed-by: Kyotaro Horiguchi
Discussion: https://postgr.es/m/20200422175754[email protected]
13 files changed:
src/backend/access/transam/twophase.c
src/backend/access/transam/xlog.c
src/backend/access/transam/xlogreader.c
src/backend/access/transam/xlogutils.c
src/backend/replication/logical/logical.c
src/backend/replication/logical/logicalfuncs.c
src/backend/replication/slotfuncs.c
src/backend/replication/walsender.c
src/bin/pg_rewind/parsexlog.c
src/bin/pg_waldump/pg_waldump.c
src/include/access/xlogreader.h
src/include/access/xlogutils.h
src/include/replication/logical.h