Fix heap_getattr() handling of fast defaults.
authorAndres Freund
Wed, 6 Feb 2019 09:09:32 +0000 (01:09 -0800)
committerAndres Freund
Wed, 6 Feb 2019 09:09:42 +0000 (01:09 -0800)
commit297d627e074ad4aa2a9936b029a4b9231f9a150e
tree0cfdb106a79fe45a103fb2711f51339f87ad3375
parent77173d0cca4df1df1f423a467e2af4a4db9a0d10
Fix heap_getattr() handling of fast defaults.

Previously heap_getattr() returned NULL for attributes with a fast
default value (c.f. 16828d5c0273), as it had no handling whatsoever
for that case.

A previous fix, 7636e5c60f, attempted to fix issues caused by this
oversight, but just expanding OLD tuples for triggers doesn't actually
solve the underlying issue.

One known consequence of this bug is that the check for HOT updates
can return the wrong result, when a previously fast-default'ed column
is set to NULL. Which in turn means that an index over a column with
fast default'ed columns might be corrupt if the underlying column(s)
allow NULLs.

Fix by handling fast default columns in heap_getattr(), remove now
superfluous expansion in GetTupleForTrigger().

Author: Andres Freund
Discussion: https://postgr.es/m/20190201162404[email protected]
Backpatch: 11, where fast defaults were introduced
src/backend/access/common/heaptuple.c
src/backend/commands/trigger.c
src/include/access/htup_details.h
src/test/regress/expected/fast_default.out
src/test/regress/sql/fast_default.sql