Neil Conway [Fri, 26 Jan 2007 17:45:42 +0000 (17:45 +0000)]
Squelch some VC++ compiler warnings. Mark float literals with the "f"
suffix, to distinguish them from doubles. Make some function declarations
and definitions use the "const" qualifier for arguments consistently.
Ignore warning 4102 ("unreferenced label"), because such warnings
are always emitted by bison-generated code. Patch from Magnus Hagander.
Bruce Momjian [Thu, 25 Jan 2007 23:34:28 +0000 (23:34 +0000)]
Update BSD/OS platform for 8.2.
Bruce Momjian [Thu, 25 Jan 2007 22:25:53 +0000 (22:25 +0000)]
Add URL for shrinking tuple to just its headers:
> http://archives.postgresql.org/pgsql-hackers/2007-01/msg01025.php
Bruce Momjian [Thu, 25 Jan 2007 21:50:49 +0000 (21:50 +0000)]
Update Win32 exception comment.
Neil Conway [Thu, 25 Jan 2007 19:48:33 +0000 (19:48 +0000)]
Add a setlocal command to the beginning of build.bat. This is required
to deal with buildenv.bat properly, so that PATH (for example) doesn't
expand infintly. Per report from Joachim Wieland, patch from Magnus.
Michael Meskes [Thu, 25 Jan 2007 16:45:25 +0000 (16:45 +0000)]
Removed compiler warning due to unneeded unsigned declaration.
Removed regression test that triggers those libc precision bugs on some archs.
Bruce Momjian [Thu, 25 Jan 2007 15:08:06 +0000 (15:08 +0000)]
Update pg_dumpall -f option description.
Bruce Momjian [Thu, 25 Jan 2007 15:05:15 +0000 (15:05 +0000)]
Correction: temp_tablespaces was implemented by Albert Cervera Areny,
with cleanup by Jaime Casanova.
Bruce Momjian [Thu, 25 Jan 2007 14:52:23 +0000 (14:52 +0000)]
Reverse out use of Py_RETURN_TRUE in plpython, only supported in Python >=
2.3.
Peter Eisentraut [Thu, 25 Jan 2007 11:53:52 +0000 (11:53 +0000)]
Various fixes in the logic of XML functions:
- Add new SQL command SET XML OPTION (also available via regular GUC) to
control the DOCUMENT vs. CONTENT option in implicit parsing and
serialization operations.
- Subtle corrections in the handling of the standalone property in
xmlroot().
- Allow xmlroot() to work on content fragments.
- Subtle corrections in the handling of the version property in
xmlconcat().
- Code refactoring for producing XML declarations.
Bruce Momjian [Thu, 25 Jan 2007 04:38:59 +0000 (04:38 +0000)]
Done:
> o -Add a GUC variable to control the tablespace for temporary objects
Bruce Momjian [Thu, 25 Jan 2007 04:35:11 +0000 (04:35 +0000)]
Add GUC temp_tablespaces to provide a default location for temporary
objects.
Jaime Casanova
Bruce Momjian [Thu, 25 Jan 2007 04:17:46 +0000 (04:17 +0000)]
Properly detoast access to bytea field pg_trigger.tgargs. Old code
might cause server crash.
Backpatch to 8.2.X.
Bruce Momjian [Thu, 25 Jan 2007 04:08:51 +0000 (04:08 +0000)]
Fix for plpython functions; return true/false for boolean,
rather than 1/0. This helps when creating trigger functions that output
SQL.
Guido Goldstein
Bruce Momjian [Thu, 25 Jan 2007 03:30:43 +0000 (03:30 +0000)]
Add 'output file' option for pg_dumpall, especially useful for Win32,
where output redirection of child processes (pg_dump) doesn't work.
Dave Page
Bruce Momjian [Thu, 25 Jan 2007 02:50:12 +0000 (02:50 +0000)]
Remove developers list from TODO list now that we have URLs to reference
discussions.
<
<
< ---------------------------------------------------------------------------
<
<
< Developers who have claimed items are:
< --------------------------------------
< * Alvaro is Alvaro Herrera
< * Andrew is Andrew Dunstan
< * Bruce is Bruce Momjian of EnterpriseDB
< * Christopher is Christopher Kings-Lynne of
< Family Health Network
< * D'Arcy is D'Arcy J.M. Cain of The Cain Gang Ltd.
< * David is David Fetter
< * Fabien is Fabien Coelho
< * Gavin is Gavin Sherry of Alcove Systems Engineering
< * Greg is Greg Sabino Mullane
< * Jan is Jan Wieck of Afilias, Inc.
< * Joe is Joe Conway
< * Karel is Karel Zak
< * Magnus is Magnus Hagander
< * Marc is Marc Fournier of PostgreSQL, Inc.
< * Matthew T. O'Connor
< * Michael is Michael Meskes of Credativ
< * Neil is Neil Conway
< * Oleg is Oleg Bartunov
< * Pavel is Pavel Stehule
< * Peter is Peter Eisentraut
< * Philip is Philip Warner of Albatross Consulting Pty. Ltd.
< * Rod is Rod Taylor
< * Simon is Simon Riggs
< * Stephan is Stephan Szabo
< * Tatsuo is Tatsuo Ishii of SRA OSS, Inc. Japan
< * Teodor is Teodor Sigaev
< * Tom is Tom Lane of Red Hat
Bruce Momjian [Thu, 25 Jan 2007 02:48:06 +0000 (02:48 +0000)]
Done:
< o Add -f to pg_dumpall
> o -Add -f to pg_dumpall
Bruce Momjian [Thu, 25 Jan 2007 02:46:33 +0000 (02:46 +0000)]
Allow pg_dumpall to specify a database name rather than the default
'template1'.
Dave Page
Bruce Momjian [Thu, 25 Jan 2007 02:30:32 +0000 (02:30 +0000)]
Add --tablespaces-only and --roles-only options to pg_dumpall.
Dave Page
Bruce Momjian [Thu, 25 Jan 2007 02:17:26 +0000 (02:17 +0000)]
Prevent WAL logging when COPY is done in the same transation that
created it.
Simon Riggs
Bruce Momjian [Wed, 24 Jan 2007 19:24:28 +0000 (19:24 +0000)]
When using MSVC, disable the building of ecpg if pthreads is not
specified.
Magnus Hagander
Tom Lane [Wed, 24 Jan 2007 17:12:17 +0000 (17:12 +0000)]
Get pg_utf_mblen(), pg_utf2wchar_with_len(), and utf2ucs() all on the same
page about the maximum UTF8 sequence length we support (4 bytes since 8.1,
3 before that). pg_utf2wchar_with_len never got updated to support 4-byte
characters at all, and in any case had a buffer-overrun risk in that it
could produce multiple pg_wchars from what mblen claims to be just one UTF8
character. The only reason we don't have a major security hole is that most
callers allocate worst-case output buffers; the sole exception in released
versions appears to be pre-8.2 iwchareq() (ie, ILIKE), which can be crashed
due to zeroing out its return address --- but AFAICS that can't be exploited
for anything more than a crash, due to inability to control what gets written
there. Per report from James Russell and Michael Fuhr.
Pre-8.1 the risk is much less, but I still think pg_utf2wchar_with_len's
behavior given an incomplete final character risks buffer overrun, so
back-patch that logic change anyway.
This patch also makes sure that UTF8 sequences exceeding the supported
length (whichever it is) are consistently treated as error cases, rather
than being treated like a valid shorter sequence in some places.
Tom Lane [Wed, 24 Jan 2007 01:25:47 +0000 (01:25 +0000)]
Relax an Assert() that has been found to be too strict in some situations
involving unions of types having typmods. Variants of the failure are known
to occur in 8.1 and up; not sure if it's possible in 8.0 and 7.4, but since
the code exists that far back, I'll just patch 'em all. Per report from
Brian Hurt.
Peter Eisentraut [Tue, 23 Jan 2007 23:39:16 +0000 (23:39 +0000)]
Simplify handling of XML error messages: Just use the string provided by
libxml as the detail message.
As per .
For converting error codes to messages, we only need to cover those codes
that we raise ourselves now.
Tom Lane [Tue, 23 Jan 2007 20:45:28 +0000 (20:45 +0000)]
Update xindex.sgml to discuss operator families.
Tom Lane [Tue, 23 Jan 2007 17:54:50 +0000 (17:54 +0000)]
Update pg_dump to support dumping operator families.
Bruce Momjian [Tue, 23 Jan 2007 16:21:17 +0000 (16:21 +0000)]
Add comment about exception lists in both winnt.h and ntstatus.h.
Alvaro Herrera [Tue, 23 Jan 2007 15:44:11 +0000 (15:44 +0000)]
This patch is required for vcbuild to work after the changes to
pg_proc.h (it's the same changes that's in gen_fmgrtab.sh in the unix
build).
Patch from Magnus Hagander.
Tom Lane [Tue, 23 Jan 2007 05:07:18 +0000 (05:07 +0000)]
Add CREATE/ALTER/DROP OPERATOR FAMILY commands, also COMMENT ON OPERATOR
FAMILY; and add FAMILY option to CREATE OPERATOR CLASS to allow adding a
class to a pre-existing family. Per previous discussion. Man, what a
tedious lot of cutting and pasting ...
Bruce Momjian [Tue, 23 Jan 2007 03:31:33 +0000 (03:31 +0000)]
Remove newline from error message because URL is gone.
Bruce Momjian [Tue, 23 Jan 2007 03:28:49 +0000 (03:28 +0000)]
Back out use of FormatMessage(), does error values, not exception
values. Point to /include/ntstatus.h for an exception list, rather than
a URL.
Bruce Momjian [Tue, 23 Jan 2007 01:45:11 +0000 (01:45 +0000)]
Print meaningfull error text for abonormal process exit on Win32, rather
than hex codes, using FormatMessage().
Bruce Momjian [Mon, 22 Jan 2007 23:06:37 +0000 (23:06 +0000)]
Update my email address in FAQ.
Tom Lane [Mon, 22 Jan 2007 20:00:40 +0000 (20:00 +0000)]
Put back planner's ability to cache the results of mergejoinscansel(),
which I had removed in the first cut of the EquivalenceClass rewrite to
simplify that patch a little. But it's still important --- in a four-way
join problem mergejoinscansel() was eating about 40% of the planning time
according to gprof. Also, improve the EquivalenceClass code to re-use
join RestrictInfos rather than generating fresh ones for each join
considered. This saves some memory space but more importantly improves
the effectiveness of caching planning info in RestrictInfos.
Bruce Momjian [Mon, 22 Jan 2007 19:38:05 +0000 (19:38 +0000)]
Use errhint() for WIN32 SIGTERM message, where possible.
Bruce Momjian [Mon, 22 Jan 2007 18:32:57 +0000 (18:32 +0000)]
Uppercase hex value.
Bruce Momjian [Mon, 22 Jan 2007 18:31:51 +0000 (18:31 +0000)]
When system() fails in Win32, report it as an exception, print the
exception value in hex, and give a URL where the value can be looked-up.
Bruce Momjian [Mon, 22 Jan 2007 02:47:56 +0000 (02:47 +0000)]
Update documenation instructions. on how to delete template1.
Tom Lane [Mon, 22 Jan 2007 02:17:30 +0000 (02:17 +0000)]
Adjust pgbench so it won't spit up on non-select queries returning
tuples, which is entirely possible with custom scripts (consider
RETURNING, EXPLAIN, etc).
Tom Lane [Mon, 22 Jan 2007 01:35:23 +0000 (01:35 +0000)]
Add COST and ROWS options to CREATE/ALTER FUNCTION, plus underlying pg_proc
columns procost and prorows, to allow simple user adjustment of the estimated
cost of a function call, as well as control of the estimated number of rows
returned by a set-returning function. We might eventually wish to extend this
to allow function-specific estimation routines, but there seems to be
consensus that we should try a simple constant estimate first. In particular
this provides a relatively simple way to control the order in which different
WHERE clauses are applied in a plan node, which is a Good Thing in view of the
fact that the recent EquivalenceClass planner rewrite made that much less
predictable than before.
Peter Eisentraut [Sun, 21 Jan 2007 09:23:29 +0000 (09:23 +0000)]
Remove some unused variables
Peter Eisentraut [Sun, 21 Jan 2007 09:19:06 +0000 (09:19 +0000)]
Put back libpq link, but make sure that libpq's in-tree directory is
mentioned before the system directories.
Tom Lane [Sun, 21 Jan 2007 00:57:15 +0000 (00:57 +0000)]
Refactor some lsyscache routines to eliminate duplicate code and save
a couple of syscache lookups in make_pathkey_from_sortinfo().
Bruce Momjian [Sat, 20 Jan 2007 23:18:38 +0000 (23:18 +0000)]
Add bitmap index URL:
>
> http://archives.postgresql.org/pgsql-hackers/2006-12/msg01107.php
Tom Lane [Sat, 20 Jan 2007 23:13:01 +0000 (23:13 +0000)]
Simplify pg_am representation of ordering-capable access methods:
provide just a boolean 'amcanorder', instead of fields that specify the
sort operator strategy numbers. We have decided to require ordering-capable
AMs to use btree-compatible strategy numbers, so the old fields are
overkill (and indeed misleading about what's allowed).
Bruce Momjian [Sat, 20 Jan 2007 23:08:20 +0000 (23:08 +0000)]
Add URL for dead space map:
>
> http://archives.postgresql.org/pgsql-hackers/2006-12/msg01188.php
> http://archives.postgresql.org/pgsql-hackers/2007-01/msg00121.php
Neil Conway [Sat, 20 Jan 2007 21:59:34 +0000 (21:59 +0000)]
Update docs for recent change to setseed() return value.
Neil Conway [Sat, 20 Jan 2007 21:47:10 +0000 (21:47 +0000)]
Make setseed() return void, rather than an int4 without any use. Per
pgsql-patches discussion of September 20, 2006. Bump the catversion.
Bruce Momjian [Sat, 20 Jan 2007 21:42:03 +0000 (21:42 +0000)]
Add documentation of memory and time units to postgresql.conf.
Backpatch to 8.2.X for new initdbs.
Tom Lane [Sat, 20 Jan 2007 21:40:25 +0000 (21:40 +0000)]
Don't use 'int' where you mean 'bool'.
Bruce Momjian [Sat, 20 Jan 2007 21:30:26 +0000 (21:30 +0000)]
Update documentation about postgresqlconf to mention default units that
match the postgresql.conf file. Also add units to descriptions that
lacked them. Wording improvements. Mention pg_settings.unit as the way
to find the default units for setting.
Backpatch to 8.2.X.
Tom Lane [Sat, 20 Jan 2007 21:30:01 +0000 (21:30 +0000)]
Fix broken markup.