D'Arcy J.M. Cain [Thu, 29 Aug 2002 12:18:20 +0000 (12:18 +0000)]
chkpass_rout returns text so change PG_RETURN_CSTRING to PG_RETURN_TEXT_P.
This is currently a cosmetic difference but I make the change now in case
the macros diverge one day.
Tatsuo Ishii [Thu, 29 Aug 2002 08:03:22 +0000 (08:03 +0000)]
Remove MULTIBYTE
Tatsuo Ishii [Thu, 29 Aug 2002 07:22:30 +0000 (07:22 +0000)]
Remove #ifdef MULTIBYTE per hackers list discussion.
Tom Lane [Thu, 29 Aug 2002 06:05:27 +0000 (06:05 +0000)]
Rephrase 'Cannot insert into a view' and related messages, per
pghackers discussion around 31-Jul-02.
Tom Lane [Thu, 29 Aug 2002 05:17:55 +0000 (05:17 +0000)]
A few more fixes for the able> fiasco.
Tatsuo Ishii [Thu, 29 Aug 2002 04:43:55 +0000 (04:43 +0000)]
update mbregress expected files
Tom Lane [Thu, 29 Aug 2002 04:38:04 +0000 (04:38 +0000)]
Produce a somewhat-useful error message, namely
ERROR: Cannot display a value of type RECORD
rather than a random integer when someone tries to SELECT a tuple
value. Per pghackers discussion around 26-May-02.
Tom Lane [Thu, 29 Aug 2002 04:12:03 +0000 (04:12 +0000)]
FOUND patch was a bit over-enthusiastic: SQL commands that are not
INSERT, UPDATE, or DELETE shouldn't change FOUND. IMHO anyway.
Also, try to make documentation a little clearer.
Tom Lane [Thu, 29 Aug 2002 03:22:01 +0000 (03:22 +0000)]
Remove support for version-0 FE/BE protocol, per pghackers discussion.
This breaks support for 6.2 or older client libraries.
Tom Lane [Thu, 29 Aug 2002 01:19:41 +0000 (01:19 +0000)]
Fix ruleutils to dump column definition lists for anonymous record types
defined in the FROM clause. From Joe Conway, with some tweaks.
Tom Lane [Thu, 29 Aug 2002 00:17:06 +0000 (00:17 +0000)]
Code review for standalone composite types, query-specified composite
types, SRFs. Not happy with memory management yet, but I'll commit these
other changes.
Tom Lane [Wed, 28 Aug 2002 22:05:46 +0000 (22:05 +0000)]
Improve description of tablefunc.
Peter Eisentraut [Wed, 28 Aug 2002 21:01:14 +0000 (21:01 +0000)]
Initial Spanish translation from Karim Mribti
Peter Eisentraut [Wed, 28 Aug 2002 20:58:45 +0000 (20:58 +0000)]
Updates from Dennis Bjorklund
Peter Eisentraut [Wed, 28 Aug 2002 20:57:22 +0000 (20:57 +0000)]
Break up the long usage messages in pg_dump and pg_restore and
unify the wording, to make life easier for translators.
from Dennis Bjorklund
Bruce Momjian [Wed, 28 Aug 2002 20:55:23 +0000 (20:55 +0000)]
Remove TIOGA files from CVS current; they remain in repositiry.
Bruce Momjian [Wed, 28 Aug 2002 20:46:47 +0000 (20:46 +0000)]
This trivial patches fixes the error message returned by CREATE INDEX
when it finds an existing relation with the same name as the
to-be-created index.
Old error message:
nconway=# create table foo (a int);
CREATE TABLE
nconway=# create index foo on foo (a);
ERROR: index named "foo" already exists
I replaced 'index' with 'relation' in the error message.
Neil Conway
Bruce Momjian [Wed, 28 Aug 2002 20:46:24 +0000 (20:46 +0000)]
backend where a statically sized buffer is written to. Most of these
should be pretty safe in practice, but it's probably better to be safe
than sorry.
I was actually looking for cases where NAMEDATALEN is assumed to be
32, but only found one. That's fixed too, as well as a few bits of
code cleanup.
Neil Conway
Bruce Momjian [Wed, 28 Aug 2002 20:18:58 +0000 (20:18 +0000)]
This is a quick patch to fix a crash in pgquery_dictresult() introduced
recently. I just ran into it while running a set of python test scripts,
and I'm not sure who the normal maintainer is for interfaces/python.
John Nield
Bruce Momjian [Wed, 28 Aug 2002 20:18:29 +0000 (20:18 +0000)]
The following small patch provides a couple of minor updates (against
CVS HEAD):
Amended "strings" regression test. TOAST tests now insert two values
with storage set to "external", to exercise properly the TOAST slice
routines which fetch only a subset of the chunks.
Changed now-misleading comment on AlterTableCreateToastTable in
tablecmds.c, because both columns of the index on a toast table are now
used.
John Gray
Bruce Momjian [Wed, 28 Aug 2002 20:17:44 +0000 (20:17 +0000)]
Add mention of foreign key dependency and SERIAL in 7.2 data restores.
Note can probably be removed after a couple of releases.
Rod Taylor
Peter Eisentraut [Wed, 28 Aug 2002 18:25:05 +0000 (18:25 +0000)]
Dump ALTER DATABASE/USER ... SET ...
Bruce Momjian [Wed, 28 Aug 2002 16:45:11 +0000 (16:45 +0000)]
Remove:
< * Remove PGPASSWORD because it is insecure on some OS's, in 7.4
Tom Lane [Wed, 28 Aug 2002 15:02:55 +0000 (15:02 +0000)]
Update info about relkind and pg_type entries for composite-types patch.
Bruce Momjian [Wed, 28 Aug 2002 14:35:37 +0000 (14:35 +0000)]
Allow FOR UPDATE to appear after LIMIT/OFFSET to match MySQL syntax and as
a more logical ordering.
Tom Lane [Tue, 27 Aug 2002 21:50:23 +0000 (21:50 +0000)]
Fix compile warning.
Peter Eisentraut [Tue, 27 Aug 2002 21:33:41 +0000 (21:33 +0000)]
Flush output streams before calling pg_dump subprocess.
Bruce Momjian [Tue, 27 Aug 2002 21:16:13 +0000 (21:16 +0000)]
Add:
> o Add SET SCHEMA
Bruce Momjian [Tue, 27 Aug 2002 21:04:58 +0000 (21:04 +0000)]
Disable use of -c and -a together in pg_dump; they don't make sense together.
Tom Lane [Tue, 27 Aug 2002 20:54:47 +0000 (20:54 +0000)]
Bring comments back in sync with code.
Bruce Momjian [Tue, 27 Aug 2002 20:29:11 +0000 (20:29 +0000)]
Throw error on pg_atoi(''), regression adjustments.
Peter Eisentraut [Tue, 27 Aug 2002 20:16:49 +0000 (20:16 +0000)]
Enable locale, so case conversion (identifier processing) and number
formatting (\timing) works correctly. Change "Total time" to "Time"
since there is nothing that "total" refers to. Remove non-multibyte
code.
Peter Eisentraut [Tue, 27 Aug 2002 18:57:26 +0000 (18:57 +0000)]
Reimplement pg_dumpall in C. Currently no change in functionality,
except that it's more robust, reconnects less often, and is NLS'ed.
Bruce Momjian [Tue, 27 Aug 2002 18:28:29 +0000 (18:28 +0000)]
Add '+' mention in \? help. More clean of \? to do.
Bruce Momjian [Tue, 27 Aug 2002 18:06:00 +0000 (18:06 +0000)]
Make change for pg_locks table.
Bruce Momjian [Tue, 27 Aug 2002 16:21:51 +0000 (16:21 +0000)]
The attached patch implements the password packet length sanity check
(using an elog(LOG) ), as well as includes a few more comment fixes.
Neil Conway
Bruce Momjian [Tue, 27 Aug 2002 16:19:46 +0000 (16:19 +0000)]
Add:
> * Allow free space map to be auto-sized or warn when it is too small
Bruce Momjian [Tue, 27 Aug 2002 15:31:32 +0000 (15:31 +0000)]
Add error code emails.
Bruce Momjian [Tue, 27 Aug 2002 15:15:23 +0000 (15:15 +0000)]
Add most of Neil Conway's cleanups.
Bruce Momjian [Tue, 27 Aug 2002 15:02:50 +0000 (15:02 +0000)]
More connection timeout cleanups.
Bruce Momjian [Tue, 27 Aug 2002 14:49:52 +0000 (14:49 +0000)]
Cleanup of libpq connection timeout code.
Bruce Momjian [Tue, 27 Aug 2002 14:17:14 +0000 (14:17 +0000)]
Add:
> * Allow REINDEX to rebuild all indexes, remove /contrib/reindex
> o Allow CLUSTER to cluster all tables, remove clusterdb
Bruce Momjian [Tue, 27 Aug 2002 14:06:05 +0000 (14:06 +0000)]
Add fsm sizes.
Tom Lane [Tue, 27 Aug 2002 04:55:12 +0000 (04:55 +0000)]
PREPARE/EXECUTE statements. Patch by Neil Conway, some kibitzing
from Tom Lane.
Bruce Momjian [Tue, 27 Aug 2002 04:30:24 +0000 (04:30 +0000)]
Done:
> o -Cluster all tables at once using pg_index.indisclustered set during
Bruce Momjian [Tue, 27 Aug 2002 04:09:01 +0000 (04:09 +0000)]
Add to mmap discussion.
Bruce Momjian [Tue, 27 Aug 2002 04:00:28 +0000 (04:00 +0000)]
This patch updates the lock listing code to use Joe Conway's new
anonymous return type SRF code. It gets rid of the superflous
'pg_locks_result' that Bruce/Tom had commented on. Otherwise, no
changes in functionality.
Neil Conway
Bruce Momjian [Tue, 27 Aug 2002 03:57:11 +0000 (03:57 +0000)]
This is a 2 line patch to src/interfaces/perl5/GNUMakefile that fixes
the 'override CPPFLAGS' to include the source directory during compile,
and makes the install target look in the proper place for the man page.
Changes are only required when building outside the source directory.
J. R. Nield
Bruce Momjian [Tue, 27 Aug 2002 03:56:35 +0000 (03:56 +0000)]
This patches replaces a few more usages of strcpy() and sprintf() when
copying into a fixed-size buffer (in this case, a buffer of
NAMEDATALEN bytes). AFAICT nothing to worry about here, but worth
fixing anyway...
Neil Conway
Bruce Momjian [Tue, 27 Aug 2002 03:55:17 +0000 (03:55 +0000)]
Cleanup of SGML
Bruce Momjian [Tue, 27 Aug 2002 03:38:28 +0000 (03:38 +0000)]
I attach a little patch to make CLUSTER set and reset the indisclustered
bit on the indexes.
I also attach clusterdb and clusterdb.sgml; both of them are blatant
rips of vacuumdb and vacuumdb.sgml, but get the job done. Please review
them, as I'm probably making a lot of mistakes with SGML and I can't
compile it here.
vacuumdb itself is not very comfortable to use when the databases have
passwords, because it has to connect once for each table (I can probably
make it connect only once for each database; should I?). Because of
this I added a mention of PGPASSWORDFILE in the documentation, but I
don't know if that is the correct place for that.
Alvaro Herrera
Bruce Momjian [Tue, 27 Aug 2002 03:06:16 +0000 (03:06 +0000)]
Add to skip list in check_guc
Bruce Momjian [Tue, 27 Aug 2002 03:02:31 +0000 (03:02 +0000)]
Comment cleanup.
Bruce Momjian [Tue, 27 Aug 2002 03:01:13 +0000 (03:01 +0000)]
Script cleanups.
Bruce Momjian [Tue, 27 Aug 2002 02:54:39 +0000 (02:54 +0000)]
Clean up script.
Bruce Momjian [Tue, 27 Aug 2002 02:52:42 +0000 (02:52 +0000)]
Add check_guc utility to compare guc.c and postgresql.conf.sample.
Bruce Momjian [Tue, 27 Aug 2002 02:50:41 +0000 (02:50 +0000)]
Fix units in postgresql.conf.
Bruce Momjian [Mon, 26 Aug 2002 23:22:47 +0000 (23:22 +0000)]
Add OS X link line example for external functions.
Bruce Momjian [Mon, 26 Aug 2002 23:14:15 +0000 (23:14 +0000)]
Add discussion of pre-write pages to WAL.
Bruce Momjian [Mon, 26 Aug 2002 23:13:37 +0000 (23:13 +0000)]
Add:
> partial page writes [wal]
Bruce Momjian [Mon, 26 Aug 2002 23:02:21 +0000 (23:02 +0000)]
Add:
> * Add CORRESPONDING BY to UNION/INTERSECT/EXCEPT
Bruce Momjian [Mon, 26 Aug 2002 22:23:07 +0000 (22:23 +0000)]
Add units to postgresql.conf file.
Bruce Momjian [Mon, 26 Aug 2002 22:02:20 +0000 (22:02 +0000)]
Remove:
< o Add plsh server-side shell language (Peter E)
Bruce Momjian [Mon, 26 Aug 2002 22:01:50 +0000 (22:01 +0000)]
*** empty log message ***
Bruce Momjian [Mon, 26 Aug 2002 21:52:00 +0000 (21:52 +0000)]
Add to selfjoin DELETE todo.
Bruce Momjian [Mon, 26 Aug 2002 21:35:32 +0000 (21:35 +0000)]
Add:
> * Allow DELETE to handle table aliases for self-joins [delete]
Bruce Momjian [Mon, 26 Aug 2002 21:35:01 +0000 (21:35 +0000)]
Add delete selfjoin item.
Bruce Momjian [Mon, 26 Aug 2002 20:03:10 +0000 (20:03 +0000)]
Add info on disabled triggers.
Bruce Momjian [Mon, 26 Aug 2002 20:02:45 +0000 (20:02 +0000)]
Add:
> * Allow triggers to be disabled [trigger]
Tom Lane [Mon, 26 Aug 2002 18:45:57 +0000 (18:45 +0000)]
Increase WIDTH_THRESHOLD from 256 to 1K. This addresses recent observation
that ANALYZE would not gather any stats for a CHAR(255) column. I still
think a width threshold is appropriate for the reasons mentioned in the
code, but we can loosen it at least.
Tom Lane [Mon, 26 Aug 2002 17:54:02 +0000 (17:54 +0000)]
Modify array operations to include array's element type OID in the
array header, and to compute sizing and alignment of array elements
the same way normal tuple access operations do --- viz, using the
tupmacs.h macros att_addlength and att_align. This makes the world
safe for arrays of cstrings or intervals, and should make it much
easier to write array-type-polymorphic functions; as examples see
the cleanups of array_out and contrib/array_iterator. By Joe Conway
and Tom Lane.
Bruce Momjian [Mon, 26 Aug 2002 17:40:27 +0000 (17:40 +0000)]
Add 'return' file.
Bruce Momjian [Mon, 26 Aug 2002 17:40:00 +0000 (17:40 +0000)]
Add return tuple count item to TODO.
Bruce Momjian [Mon, 26 Aug 2002 17:39:31 +0000 (17:39 +0000)]
Add:
> * Return proper effected tuple count from complex commands [return]
Bruce Momjian [Mon, 26 Aug 2002 17:14:29 +0000 (17:14 +0000)]
Add anther sequential scan email.
Bruce Momjian [Mon, 26 Aug 2002 01:05:43 +0000 (01:05 +0000)]
Add mention of 1 terrabyte databases.
Bruce Momjian [Mon, 26 Aug 2002 01:04:44 +0000 (01:04 +0000)]
*** empty log message ***
Bruce Momjian [Mon, 26 Aug 2002 01:04:13 +0000 (01:04 +0000)]
Add raw file discussion to performance TODO.detail.
Bruce Momjian [Mon, 26 Aug 2002 00:52:40 +0000 (00:52 +0000)]
Done:
> * -Disallow TRUNCATE on tables that are involved in referential constraints
Bruce Momjian [Mon, 26 Aug 2002 00:22:53 +0000 (00:22 +0000)]
Add to tablespaces discussion.
Bruce Momjian [Mon, 26 Aug 2002 00:19:33 +0000 (00:19 +0000)]
Add to tablespaces file.
Bruce Momjian [Sun, 25 Aug 2002 22:39:37 +0000 (22:39 +0000)]
Add Bob Devine's name to the optimizer README.
Bruce Momjian [Sun, 25 Aug 2002 20:36:14 +0000 (20:36 +0000)]
Add file describing error message format.
Bruce Momjian [Sun, 25 Aug 2002 20:30:30 +0000 (20:30 +0000)]
Add:
> * Make error messages more consistent [error]
Tom Lane [Sun, 25 Aug 2002 17:20:01 +0000 (17:20 +0000)]
Clean up comments to be careful about the distinction between variable-
width types and varlena types, since with the introduction of CSTRING as
a more-or-less-real type, these concepts aren't identical. I've tried to
use varlena consistently to denote datatypes with typlen = -1, ie, they
have a length word and are potentially TOASTable; while the term variable
width covers both varlena and cstring (and, perhaps, someday other types
with other rules for computing the actual width). No code changes in this
commit except for renaming a couple macros.
Bruce Momjian [Sun, 25 Aug 2002 14:34:24 +0000 (14:34 +0000)]
Update docs for 7.2.2 release info.
Bruce Momjian [Sun, 25 Aug 2002 12:58:44 +0000 (12:58 +0000)]
Update Japanese FAQ, from Jun Kuwamura
Tom Lane [Sat, 24 Aug 2002 15:00:47 +0000 (15:00 +0000)]
The cstring datatype can now be copied, passed around, etc. The typlen
value '-2' is used to indicate a variable-width type whose width is
computed as strlen(datum)+1. Everything that looks at typlen is updated
except for array support, which Joe Conway is working on; at the moment
it wouldn't work to try to create an array of cstring.
Bruce Momjian [Sat, 24 Aug 2002 11:24:58 +0000 (11:24 +0000)]
Done:
> * -SELECT cash_out(2) crashes because of opaque
Barry Lind [Fri, 23 Aug 2002 20:45:49 +0000 (20:45 +0000)]
Enhancements to how queries with bind values are stored internally and sent to
the server. Previously we allocated a new String object for the entire final
query we were sending to the database. If you had a big query, or especially
if you had large bind values you ended up with essentially two copies in memory.
This change will reuse the existing objects and therefore should take 1/2 the
memory it does today for a given query. This restructuring will also allow
in the future the ability to stream bytea data to the server instead of the current approach of pulling it all into memory.
I also fixed a test that was failing on a 7.2 database.
Also renamed some internal variables and some minor cleanup.
Modified Files:
jdbc/org/postgresql/core/QueryExecutor.java
jdbc/org/postgresql/jdbc1/AbstractJdbc1Connection.java
jdbc/org/postgresql/jdbc1/AbstractJdbc1Statement.java
jdbc/org/postgresql/jdbc2/AbstractJdbc2ResultSet.java
jdbc/org/postgresql/jdbc2/AbstractJdbc2Statement.java
jdbc/org/postgresql/test/jdbc2/DatabaseMetaDataTest.java
Tom Lane [Fri, 23 Aug 2002 16:41:38 +0000 (16:41 +0000)]
Further cleanup around the edges of OPAQUE/pseudotype changes. Correct
the declarations of some index access method support functions. Support
SQL functions returning VOID.
Tatsuo Ishii [Fri, 23 Aug 2002 08:19:49 +0000 (08:19 +0000)]
Adapt for SRF(Set Returning Function).
Bruce Momjian [Fri, 23 Aug 2002 04:27:19 +0000 (04:27 +0000)]
Not sure how I fixed it the first time, but here's a fix for another
instance in which the docs mention that 'NAMEDATALEN == 32".
Neil Conway
Bruce Momjian [Fri, 23 Aug 2002 03:10:44 +0000 (03:10 +0000)]
Add space.k>
Bruce Momjian [Fri, 23 Aug 2002 03:10:15 +0000 (03:10 +0000)]
Add:
> * Allow xlog directory location to be specified during initdb, perhaps
> using symlinks
Bruce Momjian [Fri, 23 Aug 2002 02:56:36 +0000 (02:56 +0000)]
Patch resolve ERROR problem for non-goog query_txt.
Teodor Sigaev
Bruce Momjian [Fri, 23 Aug 2002 02:54:18 +0000 (02:54 +0000)]
This patch updates the CREATE OPERATOR sgml docs for the new default
settings of NAMEDATALEN. I looked through the docs for other
references to NAMEDATALEN, but this is the only one I could find.
Neil Conway
Bruce Momjian [Fri, 23 Aug 2002 02:53:20 +0000 (02:53 +0000)]
Update Russian FAQ.
Bruce Momjian [Fri, 23 Aug 2002 02:46:39 +0000 (02:46 +0000)]
Add:
> * Add GUC parameter to print queries that generate errors
Tom Lane [Fri, 23 Aug 2002 01:28:17 +0000 (01:28 +0000)]
Very minor copy-editing.