Tom Lane [Mon, 20 Oct 2003 17:25:42 +0000 (17:25 +0000)]
Improve error reporting in parseTypeString(), motivated by confusing
behavior reported by Martin Marques.
Michael Meskes [Mon, 20 Oct 2003 12:54:29 +0000 (12:54 +0000)]
Install dummy sqlda.h file since this is needed for compatibility.
Tom Lane [Mon, 20 Oct 2003 01:34:33 +0000 (01:34 +0000)]
When building shared libraries on HPUX with gcc, forcibly include -lgcc
to ensure any needed compiler support routines are included. This is
arguably appropriate on *every* gcc platform, but for the moment I'll take
the conservative approach of only doing it on a platform where it's
provably useful. Per complaint from Heiko Lehmann, 13-Feb-03, as well
as personal experience --- contrib/pgstattuple has never worked for me,
but it does now.
Tom Lane [Sun, 19 Oct 2003 23:43:51 +0000 (23:43 +0000)]
Save_r, Save_t should be static not global variables.
Tom Lane [Sun, 19 Oct 2003 22:15:32 +0000 (22:15 +0000)]
Update README file to show 7.4 oidjoins relationships. The regression
test was updated previously, but documentation is lagging.
Tom Lane [Sun, 19 Oct 2003 21:36:41 +0000 (21:36 +0000)]
Adjust libpq to avoid deadlock when both client and server want to send
data, and both have filled the transmission buffers. One scenario where
this can happen was illustrated here:
http://archives.postgresql.org/pgsql-hackers/2003-04/msg00979.php
Michael Meskes [Sun, 19 Oct 2003 13:22:33 +0000 (13:22 +0000)]
Check for both Informix modes when parsing include files.
Peter Eisentraut [Sat, 18 Oct 2003 22:59:09 +0000 (22:59 +0000)]
Cleanup on --help-config: Now called --describe-config, no further options,
machine readable, without headers, not sorted. Parameter descriptions
adjusted to fit first sentence + rest convention.
Tom Lane [Sat, 18 Oct 2003 19:06:10 +0000 (19:06 +0000)]
Further work on information_schema. _pg_keyissubset() wasn't quite
fully search-path-proof yet; also, element_types view did not work for
parameters and result types of functions, because it didn't generate
the object_name for the function the same way the data_type_privileges
view does. While at it, centralize dependencies on INDEX_MAX_KEYS/
FUNC_MAX_ARGS into a function returning setof int, so that it will be
easier to fix information_schema for nonstandard values of these
parameters.
Tom Lane [Sat, 18 Oct 2003 16:52:15 +0000 (16:52 +0000)]
Repair interaction between IN-join processing and subselect pullup that
I inadvertently broke a few days ago (per report from Sean Thomas).
Add regression test case to try to catch any similar breakage in future.
Tom Lane [Sat, 18 Oct 2003 15:38:06 +0000 (15:38 +0000)]
Simplify loop test to avoid bug in AIX compiler, per Andreas.
Peter Eisentraut [Sat, 18 Oct 2003 12:53:35 +0000 (12:53 +0000)]
Information schema fixes:
Use pg_get_constraintdef instead of pg_constraint.consrc
Use UNION ALL instread of UNION
Make use of regclass type for getting OID of system catalogs
Add schema qualifications where necessary
Fix typos
Tom Lane [Sat, 18 Oct 2003 05:02:06 +0000 (05:02 +0000)]
Must free the pgParameterStatus chain in freePGconn(). My fault,
well spotted by Neil Conway.
Tom Lane [Fri, 17 Oct 2003 22:38:20 +0000 (22:38 +0000)]
Document all the system views created by initdb (several of these were
never documented anywhere, sigh). Centralize the detailed documentation
of system views into catalogs.sgml, and provide cross-references.
Tom Lane [Fri, 17 Oct 2003 18:57:01 +0000 (18:57 +0000)]
Add a listing of our SQLSTATE error codes to the documentation.
Link to it from some appropriate places.
Tom Lane [Fri, 17 Oct 2003 18:29:55 +0000 (18:29 +0000)]
Fix busted markup.
Tom Lane [Fri, 17 Oct 2003 16:49:03 +0000 (16:49 +0000)]
Fix elog tab-insertion code to insert tabs only where wanted.
Peter Eisentraut [Fri, 17 Oct 2003 11:52:06 +0000 (11:52 +0000)]
Remove automatic '()' in other branch of UNION as well.
Tom Lane [Fri, 17 Oct 2003 01:14:26 +0000 (01:14 +0000)]
Adjust display of actual runtimes in EXPLAIN output to use three fractional
digits, and label it 'ms' not 'msec', for consistency with psql's \timing
display. Per recent discussions.
Tom Lane [Fri, 17 Oct 2003 00:57:04 +0000 (00:57 +0000)]
Use pg_get_constraintdef() rather than pg_constraint.consrc; this is
a portion of a patch recently submitted by Christopher Kings-Lynne.
Applied by agreement that this is a bug fix.
Tom Lane [Fri, 17 Oct 2003 00:55:17 +0000 (00:55 +0000)]
Add note deprecating use of consrc.
Peter Eisentraut [Thu, 16 Oct 2003 23:46:17 +0000 (23:46 +0000)]
Fix bugs in referential_constraints view.
Peter Eisentraut [Thu, 16 Oct 2003 23:45:29 +0000 (23:45 +0000)]
There should not be an automatic '()' after a function name when
tab-completing.
Tom Lane [Thu, 16 Oct 2003 22:52:22 +0000 (22:52 +0000)]
Set attstattarget to -1 for all system catalog columns. All but a few
of the entries used to be zero, which I think I had deliberately done in
the name of saving cycles during ANALYZE, but it was really a rather
foolish decision. Some of the more complex views in information_schema
were getting really bad plans for lack of statistics on the columns they
were joining over.
I'm not forcing an initdb for this, but I think there will be one soon
anyway to repair some bugs in the information_schema views.
Tom Lane [Thu, 16 Oct 2003 21:37:54 +0000 (21:37 +0000)]
Avoid division by zero in estimate_num_groups() when table has no rows.
Tom Lane [Thu, 16 Oct 2003 20:59:35 +0000 (20:59 +0000)]
Ensure that all places that are complaining about exhaustion of shared
memory say 'out of shared memory'; some were doing that and some just
said 'out of memory'. Also add a HINT about increasing max_locks_per_transaction
where relevant, per suggestion from Sean Chittenden. (The former change
does not break the strings freeze; the latter does, but I think it's
worth doing anyway.)
Tom Lane [Thu, 16 Oct 2003 20:03:09 +0000 (20:03 +0000)]
Cause tab completion to do something moderately reasonable with mixed-case
identifiers --- it will now complete these correctly with double quoting.
Fix a few other issues in passing.
Bruce Momjian [Thu, 16 Oct 2003 17:38:01 +0000 (17:38 +0000)]
Add mention of SIGHUP on the postmaster manual page.
Tom Lane [Thu, 16 Oct 2003 16:50:41 +0000 (16:50 +0000)]
Fix bad interaction between NOTIFY processing and V3 extended query
protocol, per report from Igor Shevchenko. NOTIFY thought it could
do its thing if transaction blockState is TBLOCK_DEFAULT, but in
reality it had better check the low-level transaction state is
TRANS_DEFAULT as well. Formerly it was not possible to wait for the
client in a state where the first is true and the second is not ...
but now we can have such a state. Minor cleanup in StartTransaction()
as well.
Tom Lane [Thu, 16 Oct 2003 04:52:21 +0000 (04:52 +0000)]
Minor copy-editing.
Bruce Momjian [Thu, 16 Oct 2003 04:12:53 +0000 (04:12 +0000)]
Add:
> * Allow pg_dump to dump CREATE CONVERSION (Christopher)
Bruce Momjian [Thu, 16 Oct 2003 04:11:53 +0000 (04:11 +0000)]
Fix SGML markup.
Update HISTORY file.
Bruce Momjian [Thu, 16 Oct 2003 03:55:31 +0000 (03:55 +0000)]
This patch adds another item to the "migration to 7.4" list in the
HISTORY file, and attributes the shared-buffer-alignment change to
Manfred Spraul.
Neil Conway
Bruce Momjian [Thu, 16 Oct 2003 03:47:28 +0000 (03:47 +0000)]
I have run pg_autovacuum on AIX, so that can, at least loosely, be
considered "tested."
And I have turned all of the 7.4 HISTORY material into DocBook for
release.sgml
Christopher Browne
Tom Lane [Wed, 15 Oct 2003 22:23:56 +0000 (22:23 +0000)]
Cause the default CFLAGS to be -O2 -fno-strict-aliasing when using gcc,
per recent pghackers discussions. Also ensure that explicitly setting
CFLAGS in the configure environment will be honored.
Peter Eisentraut [Wed, 15 Oct 2003 10:00:20 +0000 (10:00 +0000)]
Translation updates
Peter Eisentraut [Wed, 15 Oct 2003 09:49:07 +0000 (09:49 +0000)]
New translation
Peter Eisentraut [Wed, 15 Oct 2003 09:45:34 +0000 (09:45 +0000)]
Translation update
Peter Eisentraut [Wed, 15 Oct 2003 09:39:04 +0000 (09:39 +0000)]
New translation
Tom Lane [Tue, 14 Oct 2003 22:47:12 +0000 (22:47 +0000)]
Use PQescapeString to ensure that tab-completion queries are not messed
up by quotes or backslashes in words that are being matched to database
names (per gripe from Ian Barwick, though I didn't use his patch).
Also fix possible memory leakage if _complete_with_query isn't run to
completion (not clear if that can happen or not, but be safe).
Bruce Momjian [Tue, 14 Oct 2003 19:08:00 +0000 (19:08 +0000)]
Remove void* in MemSet until we understand the gcc 3.3.1 problem better.
Bruce Momjian [Tue, 14 Oct 2003 00:48:09 +0000 (00:48 +0000)]
Add compile -O flag only for non-debug mode, per Tom
Tom Lane [Mon, 13 Oct 2003 23:48:16 +0000 (23:48 +0000)]
pull_up_subqueries() should copy the subquery before starting to modify
it. Not sure why I'd thought it would be a good idea to do differently
way back when, but Greg Stark exposed the folly of doing so ...
Bruce Momjian [Mon, 13 Oct 2003 22:47:15 +0000 (22:47 +0000)]
Back out makeNode() patch to fix gcc 3.3.1 warning.
Peter Eisentraut [Mon, 13 Oct 2003 21:39:41 +0000 (21:39 +0000)]
Remove registration message, after discussion concluded that it was of
little use.
Peter Eisentraut [Mon, 13 Oct 2003 21:38:37 +0000 (21:38 +0000)]
Translation update
Tom Lane [Mon, 13 Oct 2003 21:06:44 +0000 (21:06 +0000)]
Determine max_connections first, then see how large shared_buffers can
be made, to avoid corner cases where max_connections ends up unreasonably
small because shared_buffers is hogging too much shmem space. Per pghackers
discussion about a week ago. Also, fix the copy-newlines problem in a
more robust way, by using COPY FROM filename instead of COPY FROM STDIN;
per a suggestion from Peter.
Tom Lane [Mon, 13 Oct 2003 20:02:52 +0000 (20:02 +0000)]
Adjust setRelhassubclassInRelation() to not perform actual heap_update
when the pg_class.relhassubclass value is already correct. This should
avoid most cases of the 'tuple concurrently updated' problem that
Robert Creager recently complained about. Also remove a bunch of dead
code in StoreCatalogInheritance() --- it was still computing the complete
list of direct and indirect inheritance ancestors, though that list has
not been needed since we got rid of the pg_ipl catalog.
Bruce Momjian [Sun, 12 Oct 2003 23:19:21 +0000 (23:19 +0000)]
Use makeNode() to allocate structures that have to be cast to Node *,
rather than allocating them on the stack.
Fixes complaint from gcc 3.3.1.
Peter Eisentraut [Sun, 12 Oct 2003 19:16:36 +0000 (19:16 +0000)]
New translation
Michael Meskes [Sun, 12 Oct 2003 15:19:46 +0000 (15:19 +0000)]
Added missing "commit" in test case.
Bruce Momjian [Sat, 11 Oct 2003 19:53:45 +0000 (19:53 +0000)]
Add void * cast to MemSet to silence compiler, and add comment that we
already check for alignment.
Bruce Momjian [Sat, 11 Oct 2003 18:04:26 +0000 (18:04 +0000)]
Back out -fstrict-aliasing void* casting.
Peter Eisentraut [Sat, 11 Oct 2003 17:11:02 +0000 (17:11 +0000)]
Translation updates
Bruce Momjian [Sat, 11 Oct 2003 16:30:55 +0000 (16:30 +0000)]
This patch will stop gcc from issuing warnings about type-punned objects
when -fstrict-aliasing is turned on, as it is in the latest gcc when you
use -O2
Andrew Dunstan
Bruce Momjian [Fri, 10 Oct 2003 21:27:13 +0000 (21:27 +0000)]
Update max existing db size to 32tb.
Bruce Momjian [Fri, 10 Oct 2003 19:26:25 +0000 (19:26 +0000)]
Fix core dump on root starting pg_autovacuum.
Change conditionals to be more constent with our code
if (const == var) => if (var == const).
Peter Eisentraut [Fri, 10 Oct 2003 08:01:44 +0000 (08:01 +0000)]
Translation updates
Bruce Momjian [Fri, 10 Oct 2003 03:58:57 +0000 (03:58 +0000)]
Rename __arm__/__arm__ to __arm__/__arm, found by Neil Conway
Bruce Momjian [Fri, 10 Oct 2003 03:46:51 +0000 (03:46 +0000)]
Add NULL regression tests.
Manfred Koizar
Bruce Momjian [Fri, 10 Oct 2003 03:27:58 +0000 (03:27 +0000)]
Change Win32 rename/unlink timeout to 3 seconds.
Bruce Momjian [Fri, 10 Oct 2003 02:52:12 +0000 (02:52 +0000)]
Update Russian FAQ.
Viktor Vislobokov
Bruce Momjian [Fri, 10 Oct 2003 02:42:09 +0000 (02:42 +0000)]
Add:
> * Prevent libpq's PQfnumber() from lowercasing the column name
572d572
< * Vadim is Vadim B. Mikheev
of Sector Data
Bruce Momjian [Fri, 10 Oct 2003 02:08:42 +0000 (02:08 +0000)]
> That's a fairly useless place to put it, though, since someone would
> only think to look at sort_mem if they already had a clue. It should
> be mentioned under bulk data load (in performance tips chapter)
Attached is a doc patch that does this. The way I've worded it may not
be the best, though.
Neil Conway
Bruce Momjian [Fri, 10 Oct 2003 01:53:06 +0000 (01:53 +0000)]
Add count(*) TODO detail.
Bruce Momjian [Fri, 10 Oct 2003 01:52:15 +0000 (01:52 +0000)]
Add TODO.detail for count(*):
> to allow fast COUNT(*) queries with no WHERE clause(?) [count]
Bruce Momjian [Fri, 10 Oct 2003 01:34:51 +0000 (01:34 +0000)]
Allow pg_id to compile on Win32.
Andrew Dunstan
Bruce Momjian [Thu, 9 Oct 2003 23:41:22 +0000 (23:41 +0000)]
Add:
> o Allow PL/pgSQL to handle %TYPE arrays, e.g. tab.col%TYPE[]
Bruce Momjian [Thu, 9 Oct 2003 22:55:46 +0000 (22:55 +0000)]
Remove -pipe from compiles.
Bruce Momjian [Thu, 9 Oct 2003 19:36:27 +0000 (19:36 +0000)]
Add:
> * Have VACUUM FULL use REINDEX rather than index vacuum
Bruce Momjian [Thu, 9 Oct 2003 19:13:48 +0000 (19:13 +0000)]
About section 8.5.1.5. ("Special Values"):
I suggest adding LOCALTIMESTAMP and LOCALTIME to the first paragraph.
Maybe it should be phrased as:
The following SQL-compatible functions can be used to obtain
current datetime-related values: CURRENT_DATE, CURRENT_TIME,
CURRENT_TIMESTAMP, LOCALTIME and LOCALTIMESTAMP.
(See Section 9.8.4.)
Troels Arvin
Peter Eisentraut [Thu, 9 Oct 2003 19:13:23 +0000 (19:13 +0000)]
Make sure that -- comments extend to the end of the line. This fixes the
misscanning of this construct:
SELECT ''hello world''
-- SELECT ''goodbye world''
::text;
Peter Eisentraut [Thu, 9 Oct 2003 19:11:03 +0000 (19:11 +0000)]
Some updates
Bruce Momjian [Thu, 9 Oct 2003 19:05:09 +0000 (19:05 +0000)]
Add mention of logrotate for syslog, from Robert Treat
Bruce Momjian [Thu, 9 Oct 2003 17:11:13 +0000 (17:11 +0000)]
Update Solaris FAQ to mention -fast.
Bruce Momjian [Thu, 9 Oct 2003 16:52:45 +0000 (16:52 +0000)]
Remove -pipe on Linux, per reports from Peter.
Bruce Momjian [Thu, 9 Oct 2003 14:47:59 +0000 (14:47 +0000)]
Add -pipe compile for Linux.
Bruce Momjian [Thu, 9 Oct 2003 14:40:37 +0000 (14:40 +0000)]
Make template CFLAGS handling consistent.
Bruce Momjian [Thu, 9 Oct 2003 13:38:05 +0000 (13:38 +0000)]
Someone report me small bug in contrib/pg_dumplo today. It's problem
with a little dirty snprintf() usage which I used some years ago:
snprintf(path, BUFSIZ, "%s/lo_dump.index", path);
Karel Zak
Bruce Momjian [Thu, 9 Oct 2003 04:34:02 +0000 (04:34 +0000)]
Re-add -pipe compile flags for bsd's.
Bruce Momjian [Thu, 9 Oct 2003 04:29:40 +0000 (04:29 +0000)]
Update:
> * COMMENT ON [ CAST | CONVERSION | OPERATOR CLASS | LARGE OBJECT | LANGUAGE ]
> (Christopher)
Bruce Momjian [Thu, 9 Oct 2003 03:20:34 +0000 (03:20 +0000)]
This centralizes the optimization defaults into configure.in, rather
than having CFLAGS= in the template files.
It uses -O2 for gcc (generated by autoconf), and -O for non-gcc, unless
the template overrides it.
Bruce Momjian [Thu, 9 Oct 2003 03:17:24 +0000 (03:17 +0000)]
Add:
> * COMMENT ON [ CAST | CONVERSION | OPERATOR CLASS | LARGE OBJECT ] (Christopher)
Bruce Momjian [Thu, 9 Oct 2003 02:40:18 +0000 (02:40 +0000)]
Change "query:" to "statement:".
Have log_duration print when log_min_duration_statement prints.
Bruce Momjian [Thu, 9 Oct 2003 02:37:09 +0000 (02:37 +0000)]
Add quotes to CFLAG define.
Jan Wieck [Thu, 9 Oct 2003 01:17:07 +0000 (01:17 +0000)]
Protected access to variable m_preparedCount via synchronized
function to prevent multiple threads using automatic cursors on
the same connection from stomping over each others cursor.
Jan
Bruce Momjian [Wed, 8 Oct 2003 22:29:58 +0000 (22:29 +0000)]
Add:
<
346a346
> * Remove CREATE CONSTRAINT TRIGGER
Bruce Momjian [Wed, 8 Oct 2003 21:44:06 +0000 (21:44 +0000)]
Add 2-phase info, add Win32 URL:
< o Sample implementation in contrib/rserv
29c28,29
< * Create native Win32 port [win32]
> * Create native Win32 port, http://momjian.postgresql.org/main/writings/pgsql/win32.html
>
367c367,368
< * Two-phase commit to implement distributed transactions
> * Add two-phase commit to all distributed transactions with
> offline/readonly server status or administrator notification for failure
Peter Eisentraut [Wed, 8 Oct 2003 20:35:39 +0000 (20:35 +0000)]
New translations
Bruce Momjian [Wed, 8 Oct 2003 19:33:53 +0000 (19:33 +0000)]
Add:
> * Use background process to write dirty shared buffers to disk
Peter Eisentraut [Wed, 8 Oct 2003 18:38:49 +0000 (18:38 +0000)]
New translations
Bruce Momjian [Wed, 8 Oct 2003 18:23:08 +0000 (18:23 +0000)]
Add quotes around -O setting for consistency.
Bruce Momjian [Wed, 8 Oct 2003 18:18:04 +0000 (18:18 +0000)]
Change some awkward wording in the pg_autovacuum README file. I really
only read this because of Niel :-)
Robert Treat
Michael Meskes [Wed, 8 Oct 2003 08:28:57 +0000 (08:28 +0000)]
Removed my debug printf() call from numeric.c
Bruce Momjian [Wed, 8 Oct 2003 03:52:32 +0000 (03:52 +0000)]
Use calloc() to allocate empty structures.
Fix pg_restore tar log output bug where Special flag wasn't being
initialized; bug seen on XP.
Bruce Momjian [Wed, 8 Oct 2003 03:49:38 +0000 (03:49 +0000)]
Have log_min_duration_statement = 0 always print duration/statement.
Change log line to be "duration: ms query:"
Indent multi-line queries with a tab in the server logs.
Michael Meskes [Tue, 7 Oct 2003 18:36:46 +0000 (18:36 +0000)]
Fixed floating point exception in long=>numeric conversion.
Bruce Momjian [Tue, 7 Oct 2003 17:40:09 +0000 (17:40 +0000)]
Fix include used by entab.
Peter Eisentraut [Tue, 7 Oct 2003 08:07:56 +0000 (08:07 +0000)]
Add missing include file.
Michael Meskes [Tue, 7 Oct 2003 05:46:56 +0000 (05:46 +0000)]
Fixed error handling in Informix compat str to date conversion.