Don't pass NULL to fprintf, if a bogus connection string is given to pg_dump.

Back-patch to all supported branches.

diff --git a/src/bin/pg_dump/pg_backup_db.c b/src/bin/pg_dump/pg_backup_db.c
index 28e2a0236aed8eb012dd4c8bed85193aca8fbd50..401a6a5a647a4b4b10e0e21224a8ebb21f2c8473 100644 (file)
--- a/src/bin/pg_dump/pg_backup_db.c
+++ b/src/bin/pg_dump/pg_backup_db.c
@@ -305,7 +305,8 @@ ConnectDatabase(Archive *AHX,
    /* check to see that the backend connection was successfully made */
    if (PQstatus(AH->connection) == CONNECTION_BAD)
        die_horribly(AH, modulename, "connection to database \"%s\" failed: %s",
-                    PQdb(AH->connection), PQerrorMessage(AH->connection));
+                    PQdb(AH->connection) ? PQdb(AH->connection) : "",
+                    PQerrorMessage(AH->connection));
 
    /* check for version mismatch */
    _check_database_version(AH);