- Check for NULL before checking whether argument is an array.

        - Remove stary character from string quoting.
        - Fixed check to report missing varchar pointer implementation.

diff --git a/src/interfaces/ecpg/ChangeLog b/src/interfaces/ecpg/ChangeLog
index 20ace619deebfebe7c51933b69597e6fb1087504..dcb8d4242e1ced5c8b099a745372287e8d4d8b71 100644 (file)
--- a/src/interfaces/ecpg/ChangeLog
+++ b/src/interfaces/ecpg/ChangeLog
@@ -1929,6 +1929,12 @@ Thu Jun  2 14:22:32 CEST 2005
    - Fixed memory leak in ecpglib by adding some missing free() commands.
    - Added patch by Gavin Scott  for Intel 64bit
      hardware.
+
+Wed Aug 24 12:17:48 CEST 2005
+
+   - Check for NULL before checking whether argument is an array.
+   - Removed stray character from string quoting.
+   - Fixed check to report missing varchar pointer implementation.
    - Set ecpg library version to 5.1.
    - Set ecpg version to 4.1.1.
 

diff --git a/src/interfaces/ecpg/ecpglib/data.c b/src/interfaces/ecpg/ecpglib/data.c
index 25738796fb2e939ce5ea05a1f928ede2b9421366..252fbae3552996ca135cb9751e43a3d66229e4bd 100644 (file)
--- a/src/interfaces/ecpg/ecpglib/data.c
+++ b/src/interfaces/ecpg/ecpglib/data.c
@@ -1,4 +1,4 @@
-/* $PostgreSQL: pgsql/src/interfaces/ecpg/ecpglib/data.c,v 1.27 2004/08/29 05:06:59 momjian Exp $ */
+/* $PostgreSQL: pgsql/src/interfaces/ecpg/ecpglib/data.c,v 1.28 2005/08/24 10:34:19 meskes Exp $ */
 
 #define POSTGRES_ECPG_INTERNAL
 #include "postgres_fe.h"
@@ -50,29 +50,6 @@ ECPGget_data(const PGresult *results, int act_tuple, int act_field, int lineno,
 
    ECPGlog("ECPGget_data line %d: RESULT: %s offset: %ld array: %s\n", lineno, pval ? pval : "", offset, isarray ? "Yes" : "No");
 
-   /* pval is a pointer to the value */
-   /* let's check if it really is an array if it should be one */
-   if (isarray == ECPG_ARRAY_ARRAY)
-   {
-       if (*pval != '{')
-       {
-           ECPGraise(lineno, ECPG_DATA_NOT_ARRAY, ECPG_SQLSTATE_DATATYPE_MISMATCH, NULL);
-           return (false);
-       }
-
-       switch (type)
-       {
-           case ECPGt_char:
-           case ECPGt_unsigned_char:
-           case ECPGt_varchar:
-               break;
-
-           default:
-               pval++;
-               break;
-       }
-   }
-
    /* We will have to decode the value */
 
    /*
@@ -129,6 +106,29 @@ ECPGget_data(const PGresult *results, int act_tuple, int act_field, int lineno,
    if (value_for_indicator == -1)
        return (true);
 
+   /* pval is a pointer to the value */
+   /* let's check if it really is an array if it should be one */
+   if (isarray == ECPG_ARRAY_ARRAY)
+   {
+       if (*pval != '{')
+       {
+           ECPGraise(lineno, ECPG_DATA_NOT_ARRAY, ECPG_SQLSTATE_DATATYPE_MISMATCH, NULL);
+           return (false);
+       }
+
+       switch (type)
+       {
+           case ECPGt_char:
+           case ECPGt_unsigned_char:
+           case ECPGt_varchar:
+               break;
+
+           default:
+               pval++;
+               break;
+       }
+   }
+
    do
    {
        switch (type)

diff --git a/src/interfaces/ecpg/preproc/preproc.y b/src/interfaces/ecpg/preproc/preproc.y
index acd734ad06be1bb1da5afb9938efc6b32b1d4f09..7e55ea1d98b8d5ed101c293a5c9cebff68ad2d85 100644 (file)
--- a/src/interfaces/ecpg/preproc/preproc.y
+++ b/src/interfaces/ecpg/preproc/preproc.y
@@ -1,4 +1,4 @@
-/* $PostgreSQL: pgsql/src/interfaces/ecpg/preproc/preproc.y,v 1.309 2005/08/22 20:25:03 momjian Exp $ */
+/* $PostgreSQL: pgsql/src/interfaces/ecpg/preproc/preproc.y,v 1.310 2005/08/24 10:34:19 meskes Exp $ */
 
 /* Copyright comment */
 %{
@@ -5144,7 +5144,8 @@ variable: opt_pointer ECPGColLabel opt_array_bounds opt_initializer
                            *dim = '\0';
                    else    
                            sprintf(dim, "[%s]", dimension);
-                   if (strcmp(length, "0") == 0)
+                   /* if (strcmp(length, "0") == 0)*/
+                   if (atoi(length) <= 0)
                        mmerror(PARSE_ERROR, ET_ERROR, "pointer to varchar are not implemented");
 
                    if (strcmp(dimension, "0") == 0)