Remove inappropriate raw_expression_tree_walker() code

It was walking into the ColumnDef->compression field, which is not a
node but a string.  This code is currently not reachable (because the
compression field is only set in situations that don't go through
raw_expression_tree_walker()), but if it had been, this could have
behaved erratically.

diff --git a/src/backend/nodes/nodeFuncs.c b/src/backend/nodes/nodeFuncs.c
index 0ed8712a631388008902e024062ed90abbe0c54d..c41e6bb984cddc52cb629ea105621314e9b088df 100644 (file)
--- a/src/backend/nodes/nodeFuncs.c
+++ b/src/backend/nodes/nodeFuncs.c
@@ -4262,8 +4262,6 @@ raw_expression_tree_walker_impl(Node *node,
 
                if (WALK(coldef->typeName))
                    return true;
-               if (WALK(coldef->compression))
-                   return true;
                if (WALK(coldef->raw_default))
                    return true;
                if (WALK(coldef->collClause))