Don't run RelationInitTableAccessMethod in a long-lived context.

Some code paths in this function perform syscache lookups, which
can lead to table accesses and possibly leakage of cruft into
the caller's context.  If said context is CacheMemoryContext,
we eventually will have visible bloat.  But fixing this is no
harder than moving one memory context switch step.  (The other
callers don't have a problem.)

Andres Freund and I independently found this via valgrind testing.
Back-patch to v12 where this code was added.

Discussion: https://postgr.es/m/20210317023101[email protected]
Discussion: https://postgr.es/m/3816764.1616104288@sss.pgh.pa.us

diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c
index 467d3ce3aa6dcfa45c501501f08b60824f76fa4f..b53d92b4daed623aacf123dea26f3206047ccf9c 100644 (file)
--- a/src/backend/utils/cache/relcache.c
+++ b/src/backend/utils/cache/relcache.c
@@ -3529,6 +3529,13 @@ RelationBuildLocalRelation(const char *relname,
 
    rel->rd_rel->relam = accessmtd;
 
+   /*
+    * RelationInitTableAccessMethod will do syscache lookups, so we mustn't
+    * run it in CacheMemoryContext.  Fortunately, the remaining steps don't
+    * require a long-lived current context.
+    */
+   MemoryContextSwitchTo(oldcxt);
+
    if (relkind == RELKIND_RELATION ||
        relkind == RELKIND_SEQUENCE ||
        relkind == RELKIND_TOASTVALUE ||
@@ -3552,11 +3559,6 @@ RelationBuildLocalRelation(const char *relname,
     */
    EOXactListAdd(rel);
 
-   /*
-    * done building relcache entry.
-    */
-   MemoryContextSwitchTo(oldcxt);
-
    /* It's fully valid */
    rel->rd_isvalid = true;