A few follow-up fixes for GUC name quoting
authorPeter Eisentraut
Fri, 17 May 2024 11:48:31 +0000 (13:48 +0200)
committerPeter Eisentraut
Fri, 17 May 2024 11:48:31 +0000 (13:48 +0200)
Fixups for 17974ec259: Some messages were missed (and some were new
since the patch was originally proposed), and there was a typo
introduced.

src/backend/libpq/be-secure-openssl.c
src/backend/postmaster/bgworker.c
src/backend/postmaster/pgarch.c
src/backend/replication/logical/slotsync.c
src/backend/utils/misc/guc_tables.c

index 0caad6bed3d26273dabf2672a448b2627dadd570..39b1a66236b63c021a72c338d1b6a7c4a1a3a00a 100644 (file)
@@ -224,7 +224,7 @@ be_tls_init(bool isServerStart)
        {
            ereport(isServerStart ? FATAL : LOG,
            /*- translator: first %s is a GUC option name, second %s is its value */
-                   (errmsg("%s setting \"%s\" not supported by this build",
+                   (errmsg("\"%s\" setting \"%s\" not supported by this build",
                            "ssl_max_protocol_version",
                            GetConfigOption("ssl_max_protocol_version",
                                            false, false))));
index 97f9f28424af2912a0601cd6edb0eae3a4319ec5..fa52b6dfa832534f6e46a16b23a893d107456db1 100644 (file)
@@ -928,7 +928,7 @@ RegisterBackgroundWorker(BackgroundWorker *worker)
                                  "Up to %d background workers can be registered with the current settings.",
                                  max_worker_processes,
                                  max_worker_processes),
-                errhint("Consider increasing the configuration parameter max_worker_processes.")));
+                errhint("Consider increasing the configuration parameter \"max_worker_processes\".")));
        return;
    }
 
index 3fc8fe7d105b4f2b9e684173d2910fc48a99a71d..02f91431f5f3c510c3749aa3c29e81e8163c4197 100644 (file)
@@ -895,7 +895,7 @@ HandlePgArchInterrupts(void)
             */
            ereport(LOG,
                    (errmsg("restarting archiver process because value of "
-                           "archive_library was changed")));
+                           "\"archive_library\" was changed")));
 
            proc_exit(0);
        }
index f1f44d41eff2905216f32e521a6163de5243301a..56d3fb5d0e5bb960d37936158d75703d17fd74d4 100644 (file)
@@ -1047,7 +1047,7 @@ ValidateSlotSyncParams(int elevel)
    if (wal_level < WAL_LEVEL_LOGICAL)
        ereport(ERROR,
                errcode(ERRCODE_INVALID_PARAMETER_VALUE),
-               errmsg("slot synchronization requires wal_level >= \"logical\""));
+               errmsg("slot synchronization requires \"wal_level\" >= \"logical\""));
 
    /*
     * A physical replication slot(primary_slot_name) is required on the
index 85c8d54d4fc5594260fdbe479c9a659a18fb9fc8..46c258be2821c59eff77a9028cd7e818d066bcaf 100644 (file)
@@ -1114,7 +1114,7 @@ struct config_bool ConfigureNamesBool[] =
            gettext_noop("Continues processing past damaged page headers."),
            gettext_noop("Detection of a damaged page header normally causes PostgreSQL to "
                         "report an error, aborting the current transaction. Setting "
-                        "\"zero_damaged_page\" to true causes the system to instead report a "
+                        "\"zero_damaged_pages\" to true causes the system to instead report a "
                         "warning, zero out the damaged page, and continue processing. This "
                         "behavior will destroy data, namely all the rows on the damaged page."),
            GUC_NOT_IN_SAMPLE