Always use -fPIC, not -fpic, when building shared libraries with gcc.

On some platforms, -fpic fails for sufficiently large shared libraries.
We've mostly not hit that boundary yet, but there are some extensions
such as Citus and pglogical where it's becoming a problem.  A bit of
research suggests that the penalty for -fPIC is small, in the
single-digit-percentage range --- and there's none at all on popular
platforms such as x86_64.  So let's just default to -fPIC everywhere
and provide one less thing for extension developers to worry about.

Per complaint from Christoph Berg.  Back-patch to all supported branches.
(I did not bother to touch the recently-removed Makefiles for sco and
unixware in the back branches, though.  We'd have no way to test that
it doesn't break anything on those platforms.)

Discussion: https://postgr.es/m/20170529155850[email protected]

diff --git a/doc/src/sgml/dfunc.sgml b/doc/src/sgml/dfunc.sgml
index 6a4b7d6e970c727027552a1132de06257481095b..23af270e32c3481ea85fa8f1e7e85836eb107111 100644 (file)
--- a/doc/src/sgml/dfunc.sgml
+++ b/doc/src/sgml/dfunc.sgml
@@ -63,10 +63,10 @@
     
      
       The compiler flag to create PIC is
-      -fpic.  To create shared libraries the compiler
+      -fPIC.  To create shared libraries the compiler
       flag is -shared.
 
-gcc -fpic -c foo.c
+gcc -fPIC -c foo.c
 gcc -shared -o foo.so foo.o
 
       This is applicable as of version 3.0 of
@@ -84,14 +84,14 @@ gcc -shared -o foo.so foo.o
      
       The compiler flag of the system compiler to create
       PIC is +z.  When using
-      GCC it's -fpic. The
+      GCC it's -fPIC. The
       linker flag for shared libraries is -b.  So:
 
 cc +z -c foo.c
 
       or:
 
-gcc -fpic -c foo.c
+gcc -fPIC -c foo.c
 
       and then:
 
@@ -112,13 +112,11 @@ ld -b -o foo.sl foo.o
     
      
       The compiler flag to create PIC is
-      -fpic.  On some platforms in some situations
-      -fPIC must be used if -fpic
-      does not work.  Refer to the GCC manual for more information.
+      -fPIC.
       The compiler flag to create a shared library is
       -shared.  A complete example looks like this:
 
-cc -fpic -c foo.c
+cc -fPIC -c foo.c
 cc -shared -o foo.so foo.o
 
      
@@ -149,12 +147,12 @@ cc -bundle -flat_namespace -undefined suppress -o foo.so foo.o
     
      
       The compiler flag to create PIC is
-      -fpic.  For ELF systems, the
+      -fPIC.  For ELF systems, the
       compiler with the flag -shared is used to link
       shared libraries.  On the older non-ELF systems, ld
       -Bshareable is used.
 
-gcc -fpic -c foo.c
+gcc -fPIC -c foo.c
 gcc -shared -o foo.so foo.o
 
      
@@ -169,10 +167,10 @@ gcc -shared -o foo.so foo.o
     
      
       The compiler flag to create PIC is
-      -fpic.  ld -Bshareable is
+      -fPIC.  ld -Bshareable is
       used to link shared libraries.
 
-gcc -fpic -c foo.c
+gcc -fPIC -c foo.c
 ld -Bshareable -o foo.so foo.o
 
      
@@ -188,7 +186,7 @@ ld -Bshareable -o foo.so foo.o
      
       The compiler flag to create PIC is
       -KPIC with the Sun compiler and
-      -fpic with GCC.  To
+      -fPIC with GCC.  To
       link shared libraries, the compiler option is
       -G with either compiler or alternatively
       -shared with GCC.
@@ -198,7 +196,7 @@ cc -G -o foo.so foo.o
 
       or
 
-gcc -fpic -c foo.c
+gcc -fPIC -c foo.c
 gcc -G -o foo.so foo.o
 
      

diff --git a/src/makefiles/Makefile.linux b/src/makefiles/Makefile.linux
index 52bf0b1e2bacacb9a225309fe58b00a9c03e62f6..f4f091caef59362c6edbe797d6cc39e6e8a1e43c 100644 (file)
--- a/src/makefiles/Makefile.linux
+++ b/src/makefiles/Makefile.linux
@@ -1,15 +1,14 @@
 AROPT = crs
+
 export_dynamic = -Wl,-E
 # Use --enable-new-dtags to generate DT_RUNPATH instead of DT_RPATH.
 # This allows LD_LIBRARY_PATH to still work when needed.
 rpath = -Wl,-rpath,'$(rpathdir)',--enable-new-dtags
+
 DLSUFFIX = .so
 
-ifeq "$(findstring sparc,$(host_cpu))" "sparc"
 CFLAGS_SL = -fPIC
-else
-CFLAGS_SL = -fpic
-endif
+
 
 # Rule for building a shared library from a single .o file
 %.so: %.o

diff --git a/src/makefiles/Makefile.netbsd b/src/makefiles/Makefile.netbsd
index 31a52601aff07cc0cd85e03c40dc4d4ee35603b7..43841c15973b0c0b594fc2333f2bbdea4bcd71ae 100644 (file)
--- a/src/makefiles/Makefile.netbsd
+++ b/src/makefiles/Makefile.netbsd
@@ -9,11 +9,7 @@ endif
 
 DLSUFFIX = .so
 
-ifeq ($(findstring sparc,$(host_cpu)), sparc)
 CFLAGS_SL = -fPIC -DPIC
-else
-CFLAGS_SL = -fpic -DPIC
-endif
 
 
 # Rule for building a shared library from a single .o file

diff --git a/src/makefiles/Makefile.openbsd b/src/makefiles/Makefile.openbsd
index 7bf549330905b5156bfd3f22ee0ce27bbb906a12..d8fde49d5c8d95ee73d4c507d12a50ac94bbb7c9 100644 (file)
--- a/src/makefiles/Makefile.openbsd
+++ b/src/makefiles/Makefile.openbsd
@@ -7,11 +7,7 @@ endif
 
 DLSUFFIX = .so
 
-ifeq ($(findstring sparc,$(host_cpu)), sparc)
 CFLAGS_SL = -fPIC -DPIC
-else
-CFLAGS_SL = -fpic -DPIC
-endif
 
 
 # Rule for building a shared library from a single .o file