After PageSetAllVisible, use MarkBufferDirty.

Previously, we used SetBufferCommitInfoNeedsSave, but that's really
intended for dirty-marks we can theoretically afford to lose, such as
hint bits.  As for 9.2, the PD_ALL_VISIBLE mustn't be lost in this
way, since we could then end up with a heap page that isn't
all-visible and a visibility map page that is all visible, causing
index-only scans to return wrong answers.

diff --git a/src/backend/commands/vacuumlazy.c b/src/backend/commands/vacuumlazy.c
index 0a617e34b634658f5df0d10a82a78374c62f7c09..d2cfcc024c1ae801075b4b5bc27139c05fe58ca7 100644 (file)
--- a/src/backend/commands/vacuumlazy.c
+++ b/src/backend/commands/vacuumlazy.c
@@ -603,7 +603,7 @@ lazy_scan_heap(Relation onerel, LVRelStats *vacrelstats,
            if (!PageIsAllVisible(page))
            {
                PageSetAllVisible(page);
-               SetBufferCommitInfoNeedsSave(buf);
+               MarkBufferDirty(buf);
            }
 
            LockBuffer(buf, BUFFER_LOCK_UNLOCK);
@@ -838,7 +838,7 @@ lazy_scan_heap(Relation onerel, LVRelStats *vacrelstats,
        if (!PageIsAllVisible(page) && all_visible)
        {
            PageSetAllVisible(page);
-           SetBufferCommitInfoNeedsSave(buf);
+           MarkBufferDirty(buf);
        }
 
        /*