Revert strlen -> strnlen optimization pre-v11.

We don't have a src/port substitute for that function in older branches,
so it fails on platforms lacking the function natively.  Per buildfarm.

diff --git a/src/backend/utils/adt/xml.c b/src/backend/utils/adt/xml.c
index 102c1d983a8b4d377b668cf4d29121cfefadbad7..f8f271c6269a605610105b5c2c4c0758ff58125c 100644 (file)
--- a/src/backend/utils/adt/xml.c
+++ b/src/backend/utils/adt/xml.c
@@ -1213,15 +1213,8 @@ parse_xml_decl(const xmlChar *str, size_t *lenp,
    if (xmlStrncmp(p, (xmlChar *) "
        goto finished;
 
-   /*
-    * If next char is a name char, it's a PI like 
-    * rather than an XMLDecl, so we have done what we came to do and found no
-    * XMLDecl.
-    *
-    * We need an input length value for xmlGetUTF8Char, but there's no need
-    * to count the whole document size, so use strnlen not strlen.
-    */
-   utf8len = strnlen((const char *) (p + 5), MAX_MULTIBYTE_CHAR_LEN);
+   /* if next char is name char, it's a PI like  */
+   utf8len = strlen((const char *) (p + 5));
    utf8char = xmlGetUTF8Char(p + 5, &utf8len);
    if (PG_XMLISNAMECHAR(utf8char))
        goto finished;