Stabilize NOTIFY behavior by transmitting notifies before ReadyForQuery.

This patch ensures that, if any notify messages were received during
a just-finished transaction, they get sent to the frontend just before
not just after the ReadyForQuery message.  With libpq and other client
libraries that act similarly, this guarantees that the client will see
the notify messages as available as soon as it thinks the transaction
is done.

This probably makes no difference in practice, since in realistic
use-cases the application would have to cope with asynchronous
arrival of notify events anyhow.  However, it makes it a lot easier
to build cross-session-notify test cases with stable behavior.
I'm a bit surprised now that we've not seen any buildfarm instability
with the test cases added by commit b10f40bf0.  Tests that I intend
to add in an upcoming bug fix are definitely unstable without this.

Back-patch to 9.6, which is as far back as we can do NOTIFY testing
with the isolationtester infrastructure.

Discussion: https://postgr.es/m/13881.1574557302@sss.pgh.pa.us

diff --git a/src/backend/commands/async.c b/src/backend/commands/async.c
index 738e6ec7e2965de03134408593fa0835c6e57f09..fb944911ee9948b630bf790cea2b4af6e5996dfc 100644 (file)
--- a/src/backend/commands/async.c
+++ b/src/backend/commands/async.c
@@ -1720,11 +1720,13 @@ HandleNotifyInterrupt(void)
 /*
  * ProcessNotifyInterrupt
  *
- *     This is called just after waiting for a frontend command.  If a
- *     interrupt arrives (via HandleNotifyInterrupt()) while reading, the
- *     read will be interrupted via the process's latch, and this routine
- *     will get called.  If we are truly idle (ie, *not* inside a transaction
- *     block), process the incoming notifies.
+ *     This is called if we see notifyInterruptPending set, just before
+ *     transmitting ReadyForQuery at the end of a frontend command, and
+ *     also if a notify signal occurs while reading from the frontend.
+ *     HandleNotifyInterrupt() will cause the read to be interrupted
+ *     via the process's latch, and this routine will get called.
+ *     If we are truly idle (ie, *not* inside a transaction block),
+ *     process the incoming notifies.
  */
 void
 ProcessNotifyInterrupt(void)

diff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgres.c
index c28cc370129f63f32de81a8ac0db8cb428d2c72c..6c2db9357360a9d4cd5571fa19c8ed52f73935f9 100644 (file)
--- a/src/backend/tcop/postgres.c
+++ b/src/backend/tcop/postgres.c
@@ -4153,7 +4153,18 @@ PostgresMain(int argc, char *argv[],
            }
            else
            {
+               /* Send out notify signals and transmit self-notifies */
                ProcessCompletedNotifies();
+
+               /*
+                * Also process incoming notifies, if any.  This is mostly to
+                * ensure stable behavior in tests: if any notifies were
+                * received during the just-finished transaction, they'll be
+                * seen by the client before ReadyForQuery is.
+                */
+               if (notifyInterruptPending)
+                   ProcessNotifyInterrupt();
+
                pgstat_report_stat(false);
 
                set_ps_display("idle", false);