initdb -S should now have an explicit check that $PGDATA is valid.

The fsync code from the backend essentially assumes that somebody's already
validated PGDATA, at least to the extent of it being a readable directory.
That's safe enough for initdb's normal code path too, but "initdb -S"
doesn't have any other processing at all that touches the target directory.
To have reasonable error-case behavior, add a pg_check_dir call.
Per gripe from Peter E.

diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
index 3c35429045e6721d338d5aacabf04e2743901607..5217d9c7c3c1dbbef3dc4005f97b57e99202c771 100644 (file)
--- a/src/bin/initdb/initdb.c
+++ b/src/bin/initdb/initdb.c
@@ -3650,10 +3650,19 @@ main(int argc, char *argv[])
        exit(1);
    }
 
-   /* If we only need to fsync, just to it and exit */
+   /* If we only need to fsync, just do it and exit */
    if (sync_only)
    {
        setup_pgdata();
+
+       /* must check that directory is readable */
+       if (pg_check_dir(pg_data) <= 0)
+       {
+           fprintf(stderr, _("%s: could not access directory \"%s\": %s\n"),
+                   progname, pg_data, strerror(errno));
+           exit_nicely();
+       }
+
        fsync_pgdata();
        return 0;
    }