Have pg_dumpall return proper status on exit

diff --git a/src/bin/pg_dump/pg_dumpall b/src/bin/pg_dump/pg_dumpall
index 87c703ac01a946c184e91c8e8cdf331b70ae826b..976a05eebe1e6d5c14a91f7b1db6404cbd12fe13 100644 (file)
--- a/src/bin/pg_dump/pg_dumpall
+++ b/src/bin/pg_dump/pg_dumpall
@@ -52,5 +52,9 @@ do
    echo "${BS}connect template1 $POSTGRES_USER"
    echo "create database $DATABASE;"
    echo "${BS}connect $DATABASE $POSTGRES_USER"
-   pg_dump "$@" $DATABASE || echo "pg_dump failed on $DATABASE" 1>&2
+   pg_dump "$@" $DATABASE
+   if [ "$?" -ne 0 ]
+   then    echo "pg_dump failed on $DATABASE, exiting" 1>&2
+       exit 1
+   fi
 done