Remove broken and useless entry-count printing in HASH_DEBUG code.

init_htab(), with #define HASH_DEBUG, prints a bunch of hashtable
parameters.  It used to also print nentries, but commit 44ca4022f changed
that to "hash_get_num_entries(hctl)", which is wrong (the parameter should
be "hashp").

Rather than correct the coding, though, let's just remove that field from
the printout.  The table must be empty, since we just finished building
it, so expensively calculating the number of entries is rather pointless.
Moreover hash_get_num_entries makes assumptions (about not needing locks)
which we could do without in debugging code.

Noted by Choi Doo-Won in bug #14764.  Back-patch to 9.6 where the
faulty code was introduced.

Discussion: https://postgr.es/m/20170802032353[email protected]

diff --git a/src/backend/utils/hash/dynahash.c b/src/backend/utils/hash/dynahash.c
index a58a479ae569be3071588f674e18facbf05696eb..6f6b03c815e661a2e6eb25c6593bd1fba56b0e9a 100644 (file)
--- a/src/backend/utils/hash/dynahash.c
+++ b/src/backend/utils/hash/dynahash.c
@@ -703,7 +703,7 @@ init_htab(HTAB *hashp, long nelem)
    hctl->nelem_alloc = choose_nelem_alloc(hctl->entrysize);
 
 #if HASH_DEBUG
-   fprintf(stderr, "init_htab:\n%s%p\n%s%ld\n%s%ld\n%s%d\n%s%ld\n%s%u\n%s%x\n%s%x\n%s%ld\n%s%ld\n",
+   fprintf(stderr, "init_htab:\n%s%p\n%s%ld\n%s%ld\n%s%d\n%s%ld\n%s%u\n%s%x\n%s%x\n%s%ld\n",
            "TABLE POINTER   ", hashp,
            "DIRECTORY SIZE  ", hctl->dsize,
            "SEGMENT SIZE    ", hctl->ssize,
@@ -712,8 +712,7 @@ init_htab(HTAB *hashp, long nelem)
            "MAX BUCKET      ", hctl->max_bucket,
            "HIGH MASK       ", hctl->high_mask,
            "LOW  MASK       ", hctl->low_mask,
-           "NSEGS           ", hctl->nsegs,
-           "NENTRIES        ", hash_get_num_entries(hctl));
+           "NSEGS           ", hctl->nsegs);
 #endif
    return true;
 }