pg_archivecleanup: Add test suite

Reviewed-by: David Steele 

diff --git a/src/bin/pg_archivecleanup/.gitignore b/src/bin/pg_archivecleanup/.gitignore
index 804089070d5645591f7cdc91e2d9aa814e81c12d..bd05d00156ae987f32bf4f02a210a0f27713773a 100644 (file)
--- a/src/bin/pg_archivecleanup/.gitignore
+++ b/src/bin/pg_archivecleanup/.gitignore
@@ -1 +1,3 @@
 /pg_archivecleanup
+
+/tmp_check/

diff --git a/src/bin/pg_archivecleanup/Makefile b/src/bin/pg_archivecleanup/Makefile
index 5bda78490c2ad95b36217796e79066abfd30afa3..c5bf99db0f43159b232c2dfa6f155a90e170f8a5 100644 (file)
--- a/src/bin/pg_archivecleanup/Makefile
+++ b/src/bin/pg_archivecleanup/Makefile
@@ -25,3 +25,10 @@ uninstall:
 
 clean distclean maintainer-clean:
    rm -f pg_archivecleanup$(X) $(OBJS)
+   rm -rf tmp_check
+
+check:
+   $(prove_check)
+
+installcheck:
+   $(prove_installcheck)

diff --git a/src/bin/pg_archivecleanup/t/010_pg_archivecleanup.pl b/src/bin/pg_archivecleanup/t/010_pg_archivecleanup.pl
new file mode 100644 (file)
index 0000000..1d3a1e4
--- /dev/null
+++ b/src/bin/pg_archivecleanup/t/010_pg_archivecleanup.pl
@@ -0,0 +1,81 @@
+use strict;
+use warnings;
+use TestLib;
+use Test::More tests => 42;
+
+program_help_ok('pg_archivecleanup');
+program_version_ok('pg_archivecleanup');
+program_options_handling_ok('pg_archivecleanup');
+
+my $tempdir = TestLib::tempdir;
+
+my @walfiles = (
+   '00000001000000370000000C.gz',
+   '00000001000000370000000D',
+   '00000001000000370000000E',
+   '00000001000000370000000F.partial',
+);
+
+sub create_files
+{
+   foreach my $fn (@walfiles, 'unrelated_file')
+   {
+       open my $file, '>', "$tempdir/$fn";
+       print $file 'CONTENT';
+       close $file;
+   }
+}
+
+create_files();
+
+command_fails_like(['pg_archivecleanup'],
+                  qr/must specify archive location/,
+                  'fails if archive location is not specified');
+
+command_fails_like(['pg_archivecleanup', $tempdir],
+                  qr/must specify oldest kept WAL file/,
+                  'fails if oldest kept WAL file name is not specified');
+
+command_fails_like(['pg_archivecleanup', 'notexist', 'foo'],
+                  qr/archive location .* does not exist/,
+                  'fails if archive location does not exist');
+
+command_fails_like(['pg_archivecleanup', $tempdir, 'foo', 'bar'],
+                  qr/too many command-line arguments/,
+                  'fails with too many command-line arguments');
+
+command_fails_like(['pg_archivecleanup', $tempdir, 'foo'],
+                  qr/invalid file name argument/,
+                  'fails with invalid restart file name');
+
+{
+   # like command_like but checking stderr
+   my $stderr;
+   my $result = IPC::Run::run ['pg_archivecleanup', '-d', '-n', $tempdir, $walfiles[2]], '2>', \$stderr;
+   ok($result, "pg_archivecleanup dry run: exit code 0");
+   like($stderr, qr/$walfiles[1].*would be removed/, "pg_archivecleanup dry run: matches");
+   foreach my $fn (@walfiles)
+   {
+       ok(-f "$tempdir/$fn", "$fn not removed");
+   }
+}
+
+sub run_check
+{
+   my ($suffix, $test_name) = @_;
+
+   create_files();
+
+   command_ok(['pg_archivecleanup', '-x', '.gz', $tempdir, $walfiles[2] . $suffix],
+              "$test_name: runs");
+
+   ok(! -f "$tempdir/$walfiles[0]", "$test_name: first older WAL file was cleaned up");
+   ok(! -f "$tempdir/$walfiles[1]", "$test_name: second older WAL file was cleaned up");
+   ok(-f "$tempdir/$walfiles[2]", "$test_name: restartfile was not cleaned up");
+   ok(-f "$tempdir/$walfiles[3]", "$test_name: newer WAL file was not cleaned up");
+   ok(-f "$tempdir/unrelated_file", "$test_name: unrelated file was not cleaned up");
+}
+
+run_check('', 'pg_archivecleanup');
+run_check('.partial', 'pg_archivecleanup with .partial file');
+run_check('.00000020.backup', 'pg_archivecleanup with .backup file');