Fix pgbench's calculation of average latency, when -T is not used.

If the test duration was given in # of transactions (-t or no option),
rather as a duration (-T), the latency average was always printed as 0.
It has been broken ever since the display of latency average was added,
in 9.4.

Fabien Coelho

Discussion: 1607131015370.7486@sto>

diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
index f3d511968430028bdc577215f2d1df6a863e287f..254ca95f3de2760929baca8ae1b25009864b6c78 100644 (file)
--- a/src/bin/pgbench/pgbench.c
+++ b/src/bin/pgbench/pgbench.c
@@ -3293,9 +3293,11 @@ printResults(TState *threads, StatsData *total, instr_time total_time,
    if (throttle_delay || progress || latency_limit)
        printSimpleStats("latency", &total->latency);
    else
-       /* only an average latency computed from the duration is available */
+   {
+       /* no measurement, show average latency computed from run time */
        printf("latency average: %.3f ms\n",
-              1000.0 * duration * nclients / total->cnt);
+              1000.0 * time_include * nclients / total->cnt);
+   }
 
    if (throttle_delay)
    {