Invalidate relcache for publications defined for all tables.

Updates/Deletes on a relation were allowed even without replica identity
after we define the publication for all tables. This would later lead to
an error on subscribers. The reason was that for such publications we were
not invalidating the relcache and the publication information for
relations was not getting rebuilt. Similarly, we were not invalidating the
relcache after dropping of such publications which will prohibit
Updates/Deletes without replica identity even without any publication.

Author: Vignesh C and Hou Zhijie
Reviewed-by: Hou Zhijie, Kyotaro Horiguchi, Amit Kapila
Backpatch-through: 10, where it was introduced
Discussion: https://postgr.es/m/CALDaNm0pF6zeWqCA8TCe2sDuwFAy8fCqba=nHampCKag-qLixg@mail.gmail.com

diff --git a/src/backend/catalog/dependency.c b/src/backend/catalog/dependency.c
index 0c37fc1d53ff9b910693b97700a399d0f676f09f..85b2bbac02415a24c6d2d0e204aa45834829f9a2 100644 (file)
--- a/src/backend/catalog/dependency.c
+++ b/src/backend/catalog/dependency.c
@@ -1470,6 +1470,10 @@ doDeletion(const ObjectAddress *object, int flags)
            RemovePublicationRelById(object->objectId);
            break;
 
+       case OCLASS_PUBLICATION:
+           RemovePublicationById(object->objectId);
+           break;
+
        case OCLASS_CAST:
        case OCLASS_COLLATION:
        case OCLASS_CONVERSION:
@@ -1488,7 +1492,6 @@ doDeletion(const ObjectAddress *object, int flags)
        case OCLASS_USER_MAPPING:
        case OCLASS_DEFACL:
        case OCLASS_EVENT_TRIGGER:
-       case OCLASS_PUBLICATION:
        case OCLASS_TRANSFORM:
            DropObjectById(object);
            break;

diff --git a/src/backend/commands/publicationcmds.c b/src/backend/commands/publicationcmds.c
index 95c253c8e08ee0d91574ea1397d6c06dc2f2aeab..3b022337e05e1b31ec3b3db11c31eda95bab3df0 100644 (file)
--- a/src/backend/commands/publicationcmds.c
+++ b/src/backend/commands/publicationcmds.c
@@ -236,6 +236,11 @@ CreatePublication(CreatePublicationStmt *stmt)
        PublicationAddTables(puboid, rels, true, NULL);
        CloseTableList(rels);
    }
+   else if (stmt->for_all_tables)
+   {
+       /* Invalidate relcache so that publication info is rebuilt. */
+       CacheInvalidateRelcacheAll();
+   }
 
    table_close(rel, RowExclusiveLock);
 
@@ -498,6 +503,35 @@ RemovePublicationRelById(Oid proid)
    table_close(rel, RowExclusiveLock);
 }
 
+/*
+ * Remove the publication by mapping OID.
+ */
+void
+RemovePublicationById(Oid pubid)
+{
+   Relation    rel;
+   HeapTuple   tup;
+   Form_pg_publication pubform;
+
+   rel = table_open(PublicationRelationId, RowExclusiveLock);
+
+   tup = SearchSysCache1(PUBLICATIONOID, ObjectIdGetDatum(pubid));
+   if (!HeapTupleIsValid(tup))
+       elog(ERROR, "cache lookup failed for publication %u", pubid);
+
+   pubform = (Form_pg_publication) GETSTRUCT(tup);
+
+   /* Invalidate relcache so that publication info is rebuilt. */
+   if (pubform->puballtables)
+       CacheInvalidateRelcacheAll();
+
+   CatalogTupleDelete(rel, &tup->t_self);
+
+   ReleaseSysCache(tup);
+
+   table_close(rel, RowExclusiveLock);
+}
+
 /*
  * Open relations specified by a RangeVar list.
  * The returned tables are locked in ShareUpdateExclusiveLock mode in order to

diff --git a/src/include/commands/publicationcmds.h b/src/include/commands/publicationcmds.h
index 00e2e626e6ce3bc8e1aad974b315ed1d13b43d79..1a8fbd3d5bd6c01164d932ce0b336ee7ec6e38d2 100644 (file)
--- a/src/include/commands/publicationcmds.h
+++ b/src/include/commands/publicationcmds.h
@@ -20,6 +20,7 @@
 
 extern ObjectAddress CreatePublication(CreatePublicationStmt *stmt);
 extern void AlterPublication(AlterPublicationStmt *stmt);
+extern void RemovePublicationById(Oid pubid);
 extern void RemovePublicationRelById(Oid proid);
 
 extern ObjectAddress AlterPublicationOwner(const char *name, Oid newOwnerId);

diff --git a/src/test/regress/expected/publication.out b/src/test/regress/expected/publication.out
index 63d6ab7a4ef265b3a5286453d85f05502e274e91..c299702480270e6a6a0e0586e9c49a78e2003378 100644 (file)
--- a/src/test/regress/expected/publication.out
+++ b/src/test/regress/expected/publication.out
@@ -156,6 +156,21 @@ Tables:
 
 DROP TABLE testpub_parted1;
 DROP PUBLICATION testpub_forparted, testpub_forparted1;
+-- Test cache invalidation FOR ALL TABLES publication
+SET client_min_messages = 'ERROR';
+CREATE TABLE testpub_tbl4(a int);
+INSERT INTO testpub_tbl4 values(1);
+UPDATE testpub_tbl4 set a = 2;
+CREATE PUBLICATION testpub_foralltables FOR ALL TABLES;
+RESET client_min_messages;
+-- fail missing REPLICA IDENTITY
+UPDATE testpub_tbl4 set a = 3;
+ERROR:  cannot update table "testpub_tbl4" because it does not have a replica identity and publishes updates
+HINT:  To enable updating the table, set REPLICA IDENTITY using ALTER TABLE.
+DROP PUBLICATION testpub_foralltables;
+-- should pass after dropping the publication
+UPDATE testpub_tbl4 set a = 3;
+DROP TABLE testpub_tbl4;
 -- fail - view
 CREATE PUBLICATION testpub_fortbl FOR TABLE testpub_view;
 ERROR:  "testpub_view" is not a table

diff --git a/src/test/regress/sql/publication.sql b/src/test/regress/sql/publication.sql
index d844075368d0c56c051beb5effab21383d3a8682..04b34ee2998c5a65b50c9a56151cc13238bd998f 100644 (file)
--- a/src/test/regress/sql/publication.sql
+++ b/src/test/regress/sql/publication.sql
@@ -93,6 +93,20 @@ ALTER PUBLICATION testpub_forparted SET (publish_via_partition_root = true);
 DROP TABLE testpub_parted1;
 DROP PUBLICATION testpub_forparted, testpub_forparted1;
 
+-- Test cache invalidation FOR ALL TABLES publication
+SET client_min_messages = 'ERROR';
+CREATE TABLE testpub_tbl4(a int);
+INSERT INTO testpub_tbl4 values(1);
+UPDATE testpub_tbl4 set a = 2;
+CREATE PUBLICATION testpub_foralltables FOR ALL TABLES;
+RESET client_min_messages;
+-- fail missing REPLICA IDENTITY
+UPDATE testpub_tbl4 set a = 3;
+DROP PUBLICATION testpub_foralltables;
+-- should pass after dropping the publication
+UPDATE testpub_tbl4 set a = 3;
+DROP TABLE testpub_tbl4;
+
 -- fail - view
 CREATE PUBLICATION testpub_fortbl FOR TABLE testpub_view;
 SET client_min_messages = 'ERROR';