Remove useless casts to (const void *)

Similar to commit 7f798aca1d5, but I didn't think to look for "const"
as well.

diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c
index cc9782b7132e4c85c05ee7009d3dfa4396a49ef5..2622221809cd55c0c018456f265e90cb2c7140ad 100644 (file)
--- a/src/backend/storage/buffer/bufmgr.c
+++ b/src/backend/storage/buffer/bufmgr.c
@@ -4292,7 +4292,7 @@ DropRelationsAllBuffers(SMgrRelation *smgr_reln, int nlocators)
            RelFileLocator locator;
 
            locator = BufTagGetRelFileLocator(&bufHdr->tag);
-           rlocator = bsearch((const void *) &(locator),
+           rlocator = bsearch(&locator,
                               locators, n, sizeof(RelFileLocator),
                               rlocator_comparator);
        }
@@ -4646,7 +4646,7 @@ FlushRelationsAllBuffers(SMgrRelation *smgrs, int nrels)
            RelFileLocator rlocator;
 
            rlocator = BufTagGetRelFileLocator(&bufHdr->tag);
-           srelent = bsearch((const void *) &(rlocator),
+           srelent = bsearch(&rlocator,
                              srels, nrels, sizeof(SMgrSortArray),
                              rlocator_comparator);
        }

diff --git a/src/backend/storage/lmgr/lock.c b/src/backend/storage/lmgr/lock.c
index edc5020c6ae9a6c10d53e637e8088bf3e737e075..0576bb75b23bfdc0e072d24bbabb057a8da8a5a6 100644 (file)
--- a/src/backend/storage/lmgr/lock.c
+++ b/src/backend/storage/lmgr/lock.c
@@ -550,7 +550,7 @@ GetLockTagsMethodTable(const LOCKTAG *locktag)
 uint32
 LockTagHashCode(const LOCKTAG *locktag)
 {
-   return get_hash_value(LockMethodLockHash, (const void *) locktag);
+   return get_hash_value(LockMethodLockHash, locktag);
 }
 
 /*

diff --git a/src/bin/pg_dump/pg_backup_archiver.c b/src/bin/pg_dump/pg_backup_archiver.c
index 59e7941a0c3b52eddff4fe1008e7a2b9175d8df3..707a3fc844c32638671aa61e8b564fbe6cb2e894 100644 (file)
--- a/src/bin/pg_dump/pg_backup_archiver.c
+++ b/src/bin/pg_dump/pg_backup_archiver.c
@@ -1822,7 +1822,7 @@ ahwrite(const void *ptr, size_t size, size_t nmemb, ArchiveHandle *AH)
            size_t      avail = AH->lo_buf_size - AH->lo_buf_used;
 
            memcpy((char *) AH->lo_buf + AH->lo_buf_used, ptr, avail);
-           ptr = (const void *) ((const char *) ptr + avail);
+           ptr = (const char *) ptr + avail;
            remaining -= avail;
            AH->lo_buf_used += avail;
            dump_lo_buf(AH);

diff --git a/src/test/modules/test_tidstore/test_tidstore.c b/src/test/modules/test_tidstore/test_tidstore.c
index 6da1cb245273f2988a2f966a4a7f1264e1c7174a..25077caf8f107439c82f6df0a49c6bf5920730f7 100644 (file)
--- a/src/test/modules/test_tidstore/test_tidstore.c
+++ b/src/test/modules/test_tidstore/test_tidstore.c
@@ -292,13 +292,13 @@ check_set_block_offsets(PG_FUNCTION_ARGS)
    qsort(items.lookup_tids, items.num_tids, sizeof(ItemPointerData), itemptr_cmp);
    for (int i = 0; i < items.num_tids; i++)
    {
-       if (itemptr_cmp((const void *) &items.insert_tids[i], (const void *) &items.iter_tids[i]) != 0)
+       if (itemptr_cmp(&items.insert_tids[i], &items.iter_tids[i]) != 0)
            elog(ERROR, "TID iter array doesn't match verification array, got (%u,%u) expected (%u,%u)",
                 ItemPointerGetBlockNumber(&items.iter_tids[i]),
                 ItemPointerGetOffsetNumber(&items.iter_tids[i]),
                 ItemPointerGetBlockNumber(&items.insert_tids[i]),
                 ItemPointerGetOffsetNumber(&items.insert_tids[i]));
-       if (itemptr_cmp((const void *) &items.insert_tids[i], (const void *) &items.lookup_tids[i]) != 0)
+       if (itemptr_cmp(&items.insert_tids[i], &items.lookup_tids[i]) != 0)
            elog(ERROR, "TID lookup array doesn't match verification array, got (%u,%u) expected (%u,%u)",
                 ItemPointerGetBlockNumber(&items.lookup_tids[i]),
                 ItemPointerGetOffsetNumber(&items.lookup_tids[i]),