Fix corner case in autovacuum-forcing logic for multixact wraparound.

Since find_multixact_start() relies on SimpleLruDoesPhysicalPageExist(),
and that function looks only at the on-disk state, it's possible for it
to fail to find a page that exists in the in-memory SLRU that has not
been written yet.  If that happens, SetOffsetVacuumLimit() will
erroneously decide to force emergency autovacuuming immediately.

We should probably fix find_multixact_start() to consider the data
cached in memory as well as on the on-disk state, but that's no excuse
for SetOffsetVacuumLimit() to be stupid about the case where it can
no longer read the value after having previously succeeded in doing so.

Report by Andres Freund.

diff --git a/src/backend/access/transam/multixact.c b/src/backend/access/transam/multixact.c
index b3e60cb1dd2ba8b9c7e231f901fa9dc4a960950b..19b2a734468983aa536c2e986ea894c6349a3fc3 100644 (file)
--- a/src/backend/access/transam/multixact.c
+++ b/src/backend/access/transam/multixact.c
@@ -2680,6 +2680,18 @@ SetOffsetVacuumLimit(bool finish_setup)
                    (errmsg("oldest MultiXactId member offset unknown")));
    }
 
+   /*
+    * If we failed to get the oldest offset this time, but we have a value
+    * from a previous pass through this function, assess the need for
+    * autovacuum based on that old value rather than automatically forcing
+    * it.
+    */
+   if (prevOldestOffsetKnown && !oldestOffsetKnown)
+   {
+       oldestOffset = prevOldestOffset;
+       oldestOffsetKnown = true;
+   }
+
    /*
     * Do we need an emergency autovacuum?  If we're not sure, assume yes.
     */