Fix REASSIGN OWNED so that it works on procedural languages too.

The capability for changing language owners is new in 8.3, so that's how
far back this needs to be backpatched.

Per bug #4132 by Kirill Simonov.

diff --git a/src/backend/catalog/pg_shdepend.c b/src/backend/catalog/pg_shdepend.c
index dea315d2915d44ba8b80886b69ac11ba9b4578c5..634c795731c3df51220c5ec019b8371fc374396c 100644 (file)
--- a/src/backend/catalog/pg_shdepend.c
+++ b/src/backend/catalog/pg_shdepend.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *   $PostgreSQL: pgsql/src/backend/catalog/pg_shdepend.c,v 1.26 2008/03/26 21:10:37 alvherre Exp $
+ *   $PostgreSQL: pgsql/src/backend/catalog/pg_shdepend.c,v 1.27 2008/04/29 19:37:04 alvherre Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -32,6 +32,7 @@
 #include "catalog/pg_type.h"
 #include "commands/conversioncmds.h"
 #include "commands/defrem.h"
+#include "commands/proclang.h"
 #include "commands/schemacmds.h"
 #include "commands/tablecmds.h"
 #include "commands/typecmds.h"
@@ -1313,6 +1314,10 @@ shdepReassignOwned(List *roleids, Oid newrole)
                    AlterFunctionOwner_oid(sdepForm->objid, newrole);
                    break;
 
+               case LanguageRelationId:
+                   AlterLanguageOwner_oid(sdepForm->objid, newrole);
+                   break;
+
                default:
                    elog(ERROR, "unexpected classid %d", sdepForm->classid);
                    break;

diff --git a/src/backend/commands/proclang.c b/src/backend/commands/proclang.c
index f695cc7b420115cc2c61b45225d7b6e701e3ff90..d03b8c7e2f4054839d3100ff7f9b3df67bbb8f10 100644 (file)
--- a/src/backend/commands/proclang.c
+++ b/src/backend/commands/proclang.c
@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  * IDENTIFICATION
- *   $PostgreSQL: pgsql/src/backend/commands/proclang.c,v 1.77 2008/03/27 03:57:33 tgl Exp $
+ *   $PostgreSQL: pgsql/src/backend/commands/proclang.c,v 1.78 2008/04/29 19:37:04 alvherre Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -50,6 +50,8 @@ typedef struct
 static void create_proc_lang(const char *languageName,
                 Oid languageOwner, Oid handlerOid, Oid valOid, bool trusted);
 static PLTemplate *find_language_template(const char *languageName);
+static void AlterLanguageOwner_internal(HeapTuple tup, Relation rel,
+                           Oid newOwnerId);
 
 
 /* ---------------------------------------------------------------------
@@ -528,7 +530,6 @@ AlterLanguageOwner(const char *name, Oid newOwnerId)
 {
    HeapTuple   tup;
    Relation    rel;
-   Form_pg_language lanForm;
 
    /* Translate name for consistency with CREATE */
    name = case_translate_language_name(name);
@@ -542,6 +543,47 @@ AlterLanguageOwner(const char *name, Oid newOwnerId)
        ereport(ERROR,
                (errcode(ERRCODE_UNDEFINED_OBJECT),
                 errmsg("language \"%s\" does not exist", name)));
+
+   AlterLanguageOwner_internal(tup, rel, newOwnerId);
+   
+   ReleaseSysCache(tup);
+   
+   heap_close(rel, RowExclusiveLock);
+
+}
+
+/*
+ * Change language owner, specified by OID
+ */
+void
+AlterLanguageOwner_oid(Oid oid, Oid newOwnerId)
+{
+   HeapTuple   tup;
+   Relation    rel;
+
+   rel = heap_open(LanguageRelationId, RowExclusiveLock);
+
+   tup = SearchSysCache(LANGOID,
+                        ObjectIdGetDatum(oid),
+                        0, 0, 0);
+   if (!HeapTupleIsValid(tup))
+       elog(ERROR, "cache lookup failed for language %u", oid);
+
+   AlterLanguageOwner_internal(tup, rel, newOwnerId);
+
+   ReleaseSysCache(tup);
+
+   heap_close(rel, RowExclusiveLock);
+}
+
+/*
+ * Workhorse for AlterLanguageOwner variants
+ */
+static void
+AlterLanguageOwner_internal(HeapTuple tup, Relation rel, Oid newOwnerId)
+{
+   Form_pg_language lanForm;
+
    lanForm = (Form_pg_language) GETSTRUCT(tup);
 
    /*
@@ -599,7 +641,4 @@ AlterLanguageOwner(const char *name, Oid newOwnerId)
        changeDependencyOnOwner(LanguageRelationId, HeapTupleGetOid(tup),
                                newOwnerId);
    }
-
-   ReleaseSysCache(tup);
-   heap_close(rel, RowExclusiveLock);
 }

diff --git a/src/include/commands/proclang.h b/src/include/commands/proclang.h
index 0ae128285d19d8fc729eecfa8d514d3ed131fc02..07551dd8d56c914e4538746d8d23907546fda966 100644 (file)
--- a/src/include/commands/proclang.h
+++ b/src/include/commands/proclang.h
@@ -16,6 +16,7 @@ extern void DropProceduralLanguage(DropPLangStmt *stmt);
 extern void DropProceduralLanguageById(Oid langOid);
 extern void RenameLanguage(const char *oldname, const char *newname);
 extern void AlterLanguageOwner(const char *name, Oid newOwnerId);
+extern void AlterLanguageOwner_oid(Oid oid, Oid newOwnerId);
 extern bool PLTemplateExists(const char *languageName);
 
 #endif   /* PROCLANG_H */