Revert "Check that we have a working tar before trying to use it"

This reverts commit f920f7e799c587228227ec94356c760e3f3d5f2b.

The patch in effect fixed a problem we didn't have and caused another
instead.

Backpatch to release 14 like original

Discussion: https://postgr.es/m/3655283.1638977975@sss.pgh.pa.us

diff --git a/src/bin/pg_basebackup/t/010_pg_basebackup.pl b/src/bin/pg_basebackup/t/010_pg_basebackup.pl
index a7ded0694470a5c0ad5a64fe9fb6425d87c2ff71..e56825382c0e330ceff249c8425514ae06ca39d7 100644 (file)
--- a/src/bin/pg_basebackup/t/010_pg_basebackup.pl
+++ b/src/bin/pg_basebackup/t/010_pg_basebackup.pl
@@ -267,9 +267,11 @@ is(scalar(@tblspc_tars), 1, 'one tablespace tar was created');
 SKIP:
 {
    my $tar = $ENV{TAR};
+   # don't check for a working tar here, to accomodate various odd
+   # cases such as AIX. If tar doesn't work the init_from_backup below
+   # will fail.
    skip "no tar program available", 1
-     if (!defined $tar || $tar eq ''
-         || system_log($tar, '--version') != 0);
+     if (!defined $tar || $tar eq '');
 
    my $node2 = PostgreSQL::Test::Cluster->new('replica');