Inhibit mingw CRT's auto-globbing of command line arguments

For some reason by default the mingw C Runtime takes it upon itself to
expand program arguments that look like shell globbing characters. That
has caused much scratching of heads and mis-attribution of the causes of
some TAP test failures, so stop doing that.

This removes an inconsistency with Windows binaries built with MSVC,
which have no such behaviour.

Per suggestion from Noah Misch.

Backpatch to all live branches.

Discussion: https://postgr.es/m/20220423025927[email protected]

diff --git a/src/common/exec.c b/src/common/exec.c
index 81b810d4cfaf9d67fb7bed7557aa3fab4ce9fd05..7dd2f8c49421f734bbc444aa62a37a7d832fc07a 100644 (file)
--- a/src/common/exec.c
+++ b/src/common/exec.c
@@ -25,6 +25,11 @@
 #include 
 #include 
 
+/* Inhibit mingw CRT's auto-globbing of command line arguments */
+#if defined(WIN32) && !defined(_MSC_VER)
+extern int _CRT_glob = 0; /* 0 turns off globbing; 1 turns it on */
+#endif
+
 /*
  * Hacky solution to allow expressing both frontend and backend error reports
  * in one macro call.  First argument of log_error is an errcode() call of