Add a comment noting that FDWs don't have to implement EXCEPT or LIMIT TO.

postgresImportForeignSchema pays attention to IMPORT's EXCEPT and LIMIT TO
options, but only as an efficiency hack, not for correctness' sake.  The
FDW documentation does explain that, but someone using postgres_fdw.c
as a coding guide might not remember it, so let's add a comment here.
Per question from Regina Obe.

diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c
index 8cf5df8f571eff3efbbb87e1f4d178cff446e0ea..775eaa07da89c5c5e6d53d4b5d1150de5e8b1bd6 100644 (file)
--- a/contrib/postgres_fdw/postgres_fdw.c
+++ b/contrib/postgres_fdw/postgres_fdw.c
@@ -2675,7 +2675,11 @@ postgresImportForeignSchema(ImportForeignSchemaStmt *stmt, Oid serverOid)
 
        /*
         * Fetch all table data from this schema, possibly restricted by
-        * EXCEPT or LIMIT TO.
+        * EXCEPT or LIMIT TO.  (We don't actually need to pay any attention
+        * to EXCEPT/LIMIT TO here, because the core code will filter the
+        * statements we return according to those lists anyway.  But it
+        * should save a few cycles to not process excluded tables in the
+        * first place.)
         *
         * Note: because we run the connection with search_path restricted to
         * pg_catalog, the format_type() and pg_get_expr() outputs will always