Make pg_dump behave more sanely when built without HAVE_LIBZ.

For some reason the code to emit a warning and switch to uncompressed
output was placed down in the guts of pg_backup_archiver.c.  This is
definitely too late in the case of parallel operation (and I rather
wonder if it wasn't too late for other purposes as well).  Put it in
pg_dump.c's option-processing logic, which seems a much saner place.

Also, the default behavior with custom or directory output format was
to emit the warning telling you the output would be uncompressed.  This
seems unhelpful, so silence that case.

Back-patch to 9.3 where parallel dump was introduced.

Kyotaro Horiguchi, adjusted a bit by me

Report: <20160526.185551.242041780[email protected]>

diff --git a/src/bin/pg_dump/pg_backup_archiver.c b/src/bin/pg_dump/pg_backup_archiver.c
index 45fe25f4ec3e1fc1ffb7600f9bdda8cd76652861..bea5df020763aef83544a567c4e6e36c1f52385e 100644 (file)
--- a/src/bin/pg_dump/pg_backup_archiver.c
+++ b/src/bin/pg_dump/pg_backup_archiver.c
@@ -3413,17 +3413,7 @@ WriteHead(ArchiveHandle *AH)
    (*AH->WriteBytePtr) (AH, AH->intSize);
    (*AH->WriteBytePtr) (AH, AH->offSize);
    (*AH->WriteBytePtr) (AH, AH->format);
-
-#ifndef HAVE_LIBZ
-   if (AH->compression != 0)
-       write_msg(modulename, "WARNING: requested compression not available in this "
-                 "installation -- archive will be uncompressed\n");
-
-   AH->compression = 0;
-#endif
-
    WriteInt(AH, AH->compression);
-
    crtm = *localtime(&AH->createDate);
    WriteInt(AH, crtm.tm_sec);
    WriteInt(AH, crtm.tm_min);

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index 2fb79157841666a97bb2f233bd21c631d982fae4..fa5a7580ef5ab504ee0afc5e8ec858f50c9ce12d 100644 (file)
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -579,12 +579,21 @@ main(int argc, char **argv)
    /* Custom and directory formats are compressed by default, others not */
    if (compressLevel == -1)
    {
+#ifdef HAVE_LIBZ
        if (archiveFormat == archCustom || archiveFormat == archDirectory)
            compressLevel = Z_DEFAULT_COMPRESSION;
        else
+#endif
            compressLevel = 0;
    }
 
+#ifndef HAVE_LIBZ
+   if (compressLevel != 0)
+       write_msg(NULL, "WARNING: requested compression not available in this "
+                 "installation -- archive will be uncompressed\n");
+   compressLevel = 0;
+#endif
+
    /*
     * On Windows we can only have at most MAXIMUM_WAIT_OBJECTS (= 64 usually)
     * parallel jobs because that's the maximum limit for the