pg_dump: Fix dumping of WITH OIDS tables

A table with OIDs that was the first in the dump output would not get
dumped with OIDs enabled.  Fix that.

The reason was that the currWithOids flag was declared to be bool but
actually also takes a -1 value for "don't know yet".  But under
stdbool.h semantics, that is coerced to true, so the required SET
default_with_oids command is not output again.  Change the variable
type to char to fix that.

Reported-by: Derek Nelson 

diff --git a/src/bin/pg_dump/pg_backup_archiver.h b/src/bin/pg_dump/pg_backup_archiver.h
index 26dd0442e8bb840d1c3aa7919a0cee4443fc8695..05e9de632f41cbf0cc1a4acbe5b80bcc760c449a 100644 (file)
--- a/src/bin/pg_dump/pg_backup_archiver.h
+++ b/src/bin/pg_dump/pg_backup_archiver.h
@@ -347,7 +347,8 @@ struct _archiveHandle
    char       *currUser;       /* current username, or NULL if unknown */
    char       *currSchema;     /* current schema, or NULL */
    char       *currTablespace; /* current tablespace, or NULL */
-   bool        currWithOids;   /* current default_with_oids setting */
+   char        currWithOids;   /* current default_with_oids setting: true,
+                                * false, or -1 for unknown, forcing a SET */
 
    void       *lo_buf;
    size_t      lo_buf_used;