Don't assume that PageIsEmpty() returns true on an all-zeros page.

It does currently, and I don't see us changing that any time soon, but we
don't make that assumption anywhere else.

Per Tom Lane's suggestion. Backpatch to 9.2, like the previous patch that
added this assumption.

diff --git a/src/backend/access/spgist/spgvacuum.c b/src/backend/access/spgist/spgvacuum.c
index 36ba24de583d6464ed1e097355a541b7dae9daf6..cffcbb5a53d6b18640a29dae6c11fd5e96e67d20 100644 (file)
--- a/src/backend/access/spgist/spgvacuum.c
+++ b/src/backend/access/spgist/spgvacuum.c
@@ -653,7 +653,7 @@ spgvacuumpage(spgBulkDeleteState *bds, BlockNumber blkno)
     */
    if (!SpGistBlockIsRoot(blkno))
    {
-       if (PageIsEmpty(page))
+       if (PageIsNew(page) || PageIsEmpty(page))
        {
            RecordFreeIndexPage(index, blkno);
            bds->stats->pages_deleted++;