Fix compiler warning.

Some buildfarm members complained about an always-true test in the
SOFT_ERROR_OCCURRED macro. Fix by reading the field directly rather
than using the macro.

Reported-by: Tom Lane
Discussion: https://postgr.es/m/2144895.1729653514@sss.pgh.pa.us

diff --git a/src/backend/statistics/attribute_stats.c b/src/backend/statistics/attribute_stats.c
index c920409680a3c915e6b432c8bc2818a0a1687efc..086dceaeafee10a4c91ca5db191dd62ebed8287c 100644 (file)
--- a/src/backend/statistics/attribute_stats.c
+++ b/src/backend/statistics/attribute_stats.c
@@ -633,7 +633,7 @@ text_to_stavalues(const char *staname, FmgrInfo *array_in, Datum d, Oid typid,
 
    pfree(s);
 
-   if (SOFT_ERROR_OCCURRED(&escontext))
+   if (escontext.error_occurred)
    {
        if (elevel != ERROR)
            escontext.error_data->elevel = elevel;