pg_regress: Disable autoruns for cmd.exe on Windows

This is similar to 9886744a361b, to prevent the execution of other
programs due to autorun configurations which could influence the
postmaster startup.

This was originally applied on HEAD as of 83c75ac7fb69 without a
backpatch, but the patch has survived CI and buildfarm cycles.  I have
checked that cmd /d exists down to Windows XP, which should make this
change work correctly in the oldest branches still supported.

Discussion: https://postgr.es/m/20230922.161551.320043332510268554[email protected]
Backpatch-through: 12

diff --git a/src/test/regress/pg_regress.c b/src/test/regress/pg_regress.c
index 60d34a40b20d8cc05ed49ee540f3d325446b8d6c..57aa0de3b7adf6a41f8423cbcfd86a4bedeb3fd8 100644 (file)
--- a/src/test/regress/pg_regress.c
+++ b/src/test/regress/pg_regress.c
@@ -1235,7 +1235,7 @@ spawn_process(const char *cmdline)
        comspec = "CMD";
 
    memset(&pi, 0, sizeof(pi));
-   cmdline2 = psprintf("\"%s\" /c \"%s\"", comspec, cmdline);
+   cmdline2 = psprintf("\"%s\" /d /c \"%s\"", comspec, cmdline);
 
    if ((restrictedToken =
         CreateRestrictedProcess(cmdline2, &pi)) == 0)