Fix memory leak due to LogicalRepRelMapEntry.attrmap.

When rebuilding the relation mapping on subscribers, we were not releasing
the attribute mapping's memory which was no longer required.

The attribute mapping used in logical tuple conversion was refactored in
PG13 (by commit e1551f96e6) but we forgot to update the related code that
frees the attribute map.

Author: Hou Zhijie
Reviewed-by: Amit Langote, Amit Kapila, Shi yu
Backpatch-through: 10, where it was introduced
Discussion: https://postgr.es/m/OSZPR01MB6310F46CD425A967E4AEF736FDA49@OSZPR01MB6310.jpnprd01.prod.outlook.com

diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c
index f2258c7667177d098c25ede5e9ca2d5c2feb0c0b..db1b686fadd620e6fd203c35de8d7434b05bc8f9 100644 (file)
--- a/src/backend/replication/logical/relation.c
+++ b/src/backend/replication/logical/relation.c
@@ -145,7 +145,7 @@ logicalrep_relmap_free_entry(LogicalRepRelMapEntry *entry)
    bms_free(remoterel->attkeys);
 
    if (entry->attrmap)
-       pfree(entry->attrmap);
+       free_attrmap(entry->attrmap);
 }
 
 /*
@@ -337,6 +337,13 @@ logicalrep_rel_open(LogicalRepRelId remoteid, LOCKMODE lockmode)
        MemoryContext oldctx;
        int         i;
 
+       /* Release the no-longer-useful attrmap, if any. */
+       if (entry->attrmap)
+       {
+           free_attrmap(entry->attrmap);
+           entry->attrmap = NULL;
+       }
+
        /* Try to find and lock the relation by name. */
        relid = RangeVarGetRelid(makeRangeVar(remoterel->nspname,
                                              remoterel->relname, -1),
@@ -588,6 +595,13 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root,
        part_entry->partoid = partOid;
    }
 
+   /* Release the no-longer-useful attrmap, if any. */
+   if (entry->attrmap)
+   {
+       free_attrmap(entry->attrmap);
+       entry->attrmap = NULL;
+   }
+
    if (!entry->remoterel.remoteid)
    {
        int         i;