pgbench: Make more debug messages use common logging API
authorMichael Paquier
Fri, 10 Jan 2020 00:02:25 +0000 (09:02 +0900)
committerMichael Paquier
Fri, 10 Jan 2020 00:02:25 +0000 (09:02 +0900)
This is a follow-up of 30a3e772, making the output more consistent when
using --debug for meta-command execution.

Author: Michael Paquier
Reviewed-by: Fabien Coelho
Discussion: https://postgr.es/m/alpine.DEB.2.21.1912241100390.3339@pseudo

src/bin/pgbench/pgbench.c

index ee1134aea2fb45097c616c82468ecefa7f26fe8d..39c1a243d53ac229b54b8cbfb79eff199eb3efaf 100644 (file)
@@ -3297,10 +3297,17 @@ executeMetaCommand(CState *st, instr_time *now)
 
    if (unlikely(__pg_log_level <= PG_LOG_DEBUG))
    {
-       fprintf(stderr, "client %d executing \\%s", st->id, argv[0]);
+       PQExpBufferData buf;
+
+       initPQExpBuffer(&buf);
+
+       printfPQExpBuffer(&buf, "client %d executing \\%s", st->id, argv[0]);
        for (int i = 1; i < argc; i++)
-           fprintf(stderr, " %s", argv[i]);
-       fprintf(stderr, "\n");
+           appendPQExpBuffer(&buf, " %s", argv[i]);
+
+       pg_log_debug("%s", buf.data);
+
+       termPQExpBuffer(&buf);
    }
 
    if (command->meta == META_SLEEP)