Remove special cases for ETXTBSY from new fsync'ing logic.

The argument that this is a sufficiently-expected case to be silently
ignored seems pretty thin.  Andres had brought it up back when we were
still considering that most fsync failures should be hard errors, and it
probably would be legit not to fail hard for ETXTBSY --- but the same is
true for EROFS and other cases, which is why we gave up on hard failures.
ETXTBSY is surely not a normal case, so logging the failure seems fine
from here.

diff --git a/src/backend/storage/file/fd.c b/src/backend/storage/file/fd.c
index 09fcee92e5987d4e578ead9648dcf7386b37f281..7c88e731463d8f185e0b8b41457e5cd8478db7a1 100644 (file)
--- a/src/backend/storage/file/fd.c
+++ b/src/backend/storage/file/fd.c
@@ -2654,18 +2654,15 @@ pre_sync_fname(const char *fname, bool isdir, int elevel)
    {
        if (errno == EACCES || (isdir && errno == EISDIR))
            return;
-
-#ifdef ETXTBSY
-       if (errno == ETXTBSY)
-           return;
-#endif
-
        ereport(elevel,
                (errcode_for_file_access(),
                 errmsg("could not open file \"%s\": %m", fname)));
        return;
    }
 
+   /*
+    * We ignore errors from pg_flush_data() because this is only a hint.
+    */
    (void) pg_flush_data(fd, 0, 0);
 
    (void) CloseTransientFile(fd);
@@ -2709,12 +2706,6 @@ fsync_fname_ext(const char *fname, bool isdir, int elevel)
    {
        if (errno == EACCES || (isdir && errno == EISDIR))
            return;
-
-#ifdef ETXTBSY
-       if (errno == ETXTBSY)
-           return;
-#endif
-
        ereport(elevel,
                (errcode_for_file_access(),
                 errmsg("could not open file \"%s\": %m", fname)));

diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
index 03419387a845d5a9696f0299427eb835d70fa228..3c35429045e6721d338d5aacabf04e2743901607 100644 (file)
--- a/src/bin/initdb/initdb.c
+++ b/src/bin/initdb/initdb.c
@@ -625,12 +625,6 @@ pre_sync_fname(const char *fname, bool isdir)
    {
        if (errno == EACCES || (isdir && errno == EISDIR))
            return;
-
-#ifdef ETXTBSY
-       if (errno == ETXTBSY)
-           return;
-#endif
-
        fprintf(stderr, _("%s: could not open file \"%s\": %s\n"),
                progname, fname, strerror(errno));
        return;
@@ -690,12 +684,6 @@ fsync_fname_ext(const char *fname, bool isdir)
    {
        if (errno == EACCES || (isdir && errno == EISDIR))
            return;
-
-#ifdef ETXTBSY
-       if (errno == ETXTBSY)
-           return;
-#endif
-
        fprintf(stderr, _("%s: could not open file \"%s\": %s\n"),
                progname, fname, strerror(errno));
        return;